From: Chao Yu <yuchao0@huawei.com>
To: Daeho Jeong <daeho43@gmail.com>
Cc: Chao Yu <chao@kernel.org>, Daeho Jeong <daehojeong@google.com>,
<kernel-team@android.com>, <linux-kernel@vger.kernel.org>,
<linux-f2fs-devel@lists.sourceforge.net>
Subject: Re: [f2fs-dev] [PATCH] f2fs: prevent compressed file from being disabled after releasing cblocks
Date: Mon, 31 Aug 2020 14:06:46 +0800 [thread overview]
Message-ID: <78ffaf17-56a0-32bd-0bcf-212333b52f06@huawei.com> (raw)
In-Reply-To: <CACOAw_wZFAyyt8qPCFd-LQKpMGa1moyOqSBpUnaeM0z2Y5Z+cA@mail.gmail.com>
On 2020/8/31 11:55, Daeho Jeong wrote:
>> - open(O_RDWR)
>> - ioctl(FS_IOC_SETFLAGS, F2FS_COMPR_FL)
>> - write()
>> - ioctl(RELEASE_COMPRESS_BLOCKS) -- inode is immutable now
>> - ioctl(FS_IOC_SETFLAGS, ~F2FS_COMPR_FL) -- Should we allow to update immutable inode?
>> as we know, normally, immutable inode should deny open(O_WRONLY or O_RDWR) and later update.
>>
>
> For this case, with this patch we'll return -EINVAL for
> ioctl(FS_IOC_SETFLAGS, ~F2FS_COMPR_FL).
> I thought RESERVE_COMPRESS_BLOCKS ioctl is always required to get the
> file to normal mode after RELEASE_COMPRESS_BLOCKS is called.
That's an example, after compressed block release, shouldn't we disallow other ioctl
interface which updates immutable inode?
> .
>
next prev parent reply other threads:[~2020-08-31 6:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 5:46 [PATCH] f2fs: prevent compressed file from being disabled after releasing cblocks Daeho Jeong
2020-08-30 3:23 ` [f2fs-dev] " Chao Yu
2020-08-30 23:42 ` Daeho Jeong
2020-08-31 1:24 ` Chao Yu
2020-08-31 1:44 ` Daeho Jeong
2020-08-31 2:31 ` Chao Yu
2020-08-31 3:55 ` Daeho Jeong
2020-08-31 6:06 ` Chao Yu [this message]
2020-08-31 6:15 ` Daeho Jeong
2020-08-31 6:22 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78ffaf17-56a0-32bd-0bcf-212333b52f06@huawei.com \
--to=yuchao0@huawei.com \
--cc=chao@kernel.org \
--cc=daeho43@gmail.com \
--cc=daehojeong@google.com \
--cc=kernel-team@android.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox