From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932482AbbJPT0P (ORCPT ); Fri, 16 Oct 2015 15:26:15 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:57627 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932237AbbJPT0N (ORCPT ); Fri, 16 Oct 2015 15:26:13 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Brian Norris , Mark Rutland , devicetree@vger.kernel.org, Florian Fainelli , Pawel Moll , Anup Patel , Scott Branden , Ian Campbell , Catalin Marinas , Kumar Gala , Will Deacon , linux-kernel@vger.kernel.org, Vikram Prakash , Rob Herring , linux-mtd@lists.infradead.org, Sandeep Tripathy , Ray Jui , Pramod KUMAR , bcm-kernel-feedback-list@broadcom.com, David Woodhouse Subject: Re: [PATCH v2 2/4] mtd: nand: Allow MTD_NAND_BRCMNAND to be selected for ARM64 Date: Fri, 16 Oct 2015 21:25:57 +0200 Message-ID: <7901695.AWo8cP6Hz1@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20151016165445.GG108923@google.com> References: <1444986537-28387-1-git-send-email-anup.patel@broadcom.com> <5673177.0QYFhMPCBq@wuerfel> <20151016165445.GG108923@google.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:R/8CYglgnmA8mcAHDsnJnCeq3ifErtpFPbLFLYvtc2nunFftLMV AFSNJPkqcd6iZVTtuJqAl73cZkJyR3YnFKJh/Tzq7XBz81Dq9UHm94uiQ928PjmZbg13N2e 0F4Zd799T8OCjNL59wgjLYCXHznhZ8HdaCjg2UJ+kl8pzZqOBq4q69SuaDRqpHogxF4fUlS UduHB2M7LV9PNPpK0wOfA== X-UI-Out-Filterresults: notjunk:1;V01:K0:rpeSz+XmQSc=:0/AlY2FmlL8rHLE2PoBNi1 bdRbfBCeUeWxpslCaL4lfvTAZPRYm9PILDU6azwB0E/VfXekgSzGOtqu2g2yWlBhDtb1XE6t/ peO3njga48ZEXL8XhXhUhs+L1q6d6gv0i5CexlvgwJ1kPhB1vLeaR/CADDwh9PZQ6yKIR0hFu PVy27JUsKWj8tjCm7XWOoowcgo/E+A1HYRWccLO3Wxgmflvl/GXqN1Q3fxSUWmwOrXBDWxtCs G5qGxSQD5xVcl1wV9Rr1tAwcCLre8a9Nu0BSoUW7lGDO3pkAO8ef1lMrM6VgGIo59NjP/IH0p aMd6SZL0ANTYvPf0WZMZCb5NjU5uikejb1DlMdEH00D2PlHKBp/KC7dLs0B41JDHYUkBIWMbL jn82kg92ZGFZiC+EEKSEWgHazKDt/aXFvFhhetS96uzv+tlQIqfKs0RPv1i6dPJy+M91B04pJ pZPPEfmCESR3LSAzRlv8G2f0Fu4eZbRQLvltSvWHXK/Q8bzyMmNEpEwS9jRIjY7l97h0bG5p6 ET4cCQ1YPrZoO2uV7tJktazO7TcnilqCH50KSbWOiI/1UTKeOKwwGcP9S4/PWzpZwBOMkzQQo 8uPY24OqmdG1ZLEaYx+k2VVJyzR1EYfKgx5Ih90Wgjw2fAeGVedOOXtWL9NUtfPKUnoBcqKO0 cqdlVb5ltD9N7yB2GNTy9DRQ7AvcGD5DBHoK8O8f6ugtN3yixPYKM24KHS1msBWMgAA50TW7H oE2L6v7ZQEBQGMEq Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 16 October 2015 09:54:45 Brian Norris wrote: > > MTD_NAND_BRCMNAND uses the generic nand functions, but is currently allowed > > to be built without CONFIG_MTD_NAND, which results in a link error: > > > > drivers/built-in.o: In function `brcmnand_remove': > > coresight-replicator.c:(.text+0x17ae6c): undefined reference to `nand_release' > > drivers/built-in.o: In function `brcmnand_probe': > > coresight-replicator.c:(.text+0x17d4b4): undefined reference to `nand_scan_ident' > > coresight-replicator.c:(.text+0x17d948): undefined reference to `nand_scan_tail' > > How did you get this? MTD_NAND_BRCMNAND is surrounded in the > 'if MTD_NAND' block, which implicitly generates a MTD_NAND dependency. > And I can confirm that in menuconfig, I see this when I disable MTD_NAND > and search for BRCMNAND: > > Symbol: MTD_NAND_BRCMNAND [=n] > Type : tristate > Prompt: Broadcom STB NAND controller > Location: > -> Device Drivers > -> Memory Technology Device (MTD) support (MTD [=y]) > (1) -> NAND Device Support (MTD_NAND [=n]) > Defined at drivers/mtd/nand/Kconfig:394 > Depends on: MTD [=y] && MTD_NAND [=n] && (ARM [=y] || ARM64 || MIPS) Sorry, can't reproduce it any more. My patch is dated June 4, so it was probably broken then but got fixed since. I normally try to verify that the patches are still needed before I send them, but this time I only saw the current discussion and remembered something vague about it and sent what I had in my backlog of the randconfig-fixes series. Sorry for the confusion. Arnd