From: Shuah Khan <skhan@linuxfoundation.org>
To: Benjamin Tissoires <bentiss@kernel.org>, Yun Lu <luyun@kylinos.cn>
Cc: jikos@kernel.org, shuah@kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftest: hid: add missing run-hid-tools-tests.sh
Date: Mon, 30 Sep 2024 14:57:26 -0600 [thread overview]
Message-ID: <7910784d-18c2-4e72-9dd8-6b8bd1b9dd0b@linuxfoundation.org> (raw)
In-Reply-To: <mimf5cv52q747fwhafr7pv6lgxyyt3rauz373e7hoinpqycmha@2oncke2rw2sc>
On 9/30/24 02:38, Benjamin Tissoires wrote:
> On Sep 29 2024, Yun Lu wrote:
>> The HID test cases actually run tests using the run-hid-tools-tests.sh
>> script. However, if installed with "make install", the run-hid-tools-tests.sh
>> script will not be copied over, resulting in the following error message.
>>
>> make -C tools/testing/selftests/ TARGETS=hid install \
>> INSTALL_PATH=$KSFT_INSTALL_PATH
>>
>> cd $KSFT_INSTALL_PATH
>> ./run_kselftest.sh -c hid
>>
>> selftests: hid: hid-core.sh
>> bash: ./run-hid-tools-tests.sh: No such file or directory
>>
>> So add the run-hid-tools-tests.sh script to the TEST_FILES in the Makefile.
>>
>
> I assume we probably also want:
>
> Cc: stable@vger.kernel.org
>
>> Signed-off-by: Yun Lu <luyun@kylinos.cn>
>
> Not sure about the timing regarding our next PR to Linus, so in any cases:
>
> Acked-by: Benjamin Tissoires <bentiss@kernel.org>
Thank you. This commit appears to be right one for Fixes tag?
Is this the right commit for Fixes tag:
Fixes: commit ffb85d5c9e80 ("selftests: hid: import hid-tools hid-core tests")
Will apply with this tag added to linux-kselftest fixes for next rc
once I get conformation.
thanks,
-- Shuah
next prev parent reply other threads:[~2024-09-30 20:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-29 8:55 [PATCH] selftest: hid: add missing run-hid-tools-tests.sh Yun Lu
2024-09-30 8:38 ` Benjamin Tissoires
2024-09-30 20:57 ` Shuah Khan [this message]
2024-10-01 2:43 ` luyun
2024-10-01 14:40 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7910784d-18c2-4e72-9dd8-6b8bd1b9dd0b@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=bentiss@kernel.org \
--cc=jikos@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=luyun@kylinos.cn \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox