Re: [PATCH v3 2/3] media: qcom: camss: Add SM6350 support

David Heidelberg
2026-02-15T12:52:26Z

On 13/02/2026 14:15, Luca Weiss wrote:
> Add the necessary support for CAMSS on the SM6350 SoC.
>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
> .../platform/qcom/camss/camss-csiphy-3ph-1-0.c | 125 ++++++++++
> drivers/media/platform/qcom/camss/camss-vfe.c | 2 +
> drivers/media/platform/qcom/camss/camss.c | 261 +++++++++++++++++++++
> drivers/media/platform/qcom/camss/camss.h | 1 +
> 4 files changed, 389 insertions(+)
>
> diff --git a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
> index 415483274552..2b0c21c90e30 100644
> --- a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
> +++ b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
> @@ -399,6 +399,126 @@ csiphy_lane_regs lane_regs_sm8250[] = {
> {0x0884, 0x01, 0x00, CSIPHY_DEFAULT_PARAMS},
> };
>
> +/* GEN2 1.2.3 2PH */
> +static const struct
> +csiphy_lane_regs lane_regs_sm6350[] = {
> + {0x0030, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0904, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0910, 0x00, 0x00, CSIPHY_DEFAULT_PARAMS},
> + {0x0900, 0x0F, 0x00, CSIPHY_DEFAULT_PARAMS},

hex numbers should be lowercase I've been told, otherwise LGTM :)

David