From: Keith Owens <kaos@ocs.com.au>
To: Kai Germaschewski <kai@tp1.ruhr-uni-bochum.de>
Cc: Jason Thomas <jason@topic.com.au>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] link errors with internal calls to devexit functions
Date: Sat, 22 Dec 2001 20:13:37 +1100 [thread overview]
Message-ID: <7928.1009012417@kao2.melbourne.sgi.com> (raw)
In-Reply-To: Your message of "Sat, 22 Dec 2001 10:04:19 BST." <Pine.LNX.4.33.0112220953400.1352-100000@vaio>
On Sat, 22 Dec 2001 10:04:19 +0100 (CET),
Kai Germaschewski <kai@tp1.ruhr-uni-bochum.de> wrote:
>I'd rather think that the patch (and the original code) is broken, as it
>seems we call an __devexit function from an init function. So
>the correct fix is to remove the __devexit attribute from the offending
>functions.
Andrew Morton said the same thing and I agree. The code is broken, no
amount of fancy wrappers will fix that. This is the perfect example of
why the new binutils are good, they are catching broken code.
next prev parent reply other threads:[~2001-12-22 9:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-22 2:57 [PATCH] link errors with internal calls to devexit functions Jason Thomas
2001-12-22 5:05 ` Keith Owens
2001-12-22 5:26 ` Andrew Morton
2001-12-22 9:04 ` Kai Germaschewski
2001-12-22 9:13 ` Keith Owens [this message]
2001-12-25 17:59 ` Legacy Fishtank
2001-12-25 17:56 ` Legacy Fishtank
-- strict thread matches above, loose matches on Subject: below --
2002-01-09 4:40 Jason Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7928.1009012417@kao2.melbourne.sgi.com \
--to=kaos@ocs.com.au \
--cc=jason@topic.com.au \
--cc=kai@tp1.ruhr-uni-bochum.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox