From: Jens Axboe <axboe@fb.com>
To: Colin King <colin.king@canonical.com>,
Ming Lei <tom.leiming@gmail.com>, Hannes Reinecke <hare@suse.de>,
Omar Sandoval <osandov@fb.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: <kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][-next] loop: fix incorrect nesting levels on braces in nested if statements
Date: Fri, 9 Jun 2017 09:57:49 -0600 [thread overview]
Message-ID: <7929f1eb-d796-6eba-52de-3c19ddcd2723@fb.com> (raw)
In-Reply-To: <20170609155425.21260-1-colin.king@canonical.com>
On 06/09/2017 09:54 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Adding another set of braces clarifies the block and ensures that
> both the setting of err and the error exit are executed on the
> deepest nested if statement.
>
> Detected by CoverityScan, CID#1440959 ("Nesting level does not
> match indentation")
Already fixed:
http://git.kernel.dk/cgit/linux-block/commit/?h=for-4.13/block&id=b040ad9cf6a169cc000a5324fcada695dfa1f4b3
--
Jens Axboe
prev parent reply other threads:[~2017-06-09 15:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 15:54 [PATCH][-next] loop: fix incorrect nesting levels on braces in nested if statements Colin King
2017-06-09 15:57 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7929f1eb-d796-6eba-52de-3c19ddcd2723@fb.com \
--to=axboe@fb.com \
--cc=akpm@linux-foundation.org \
--cc=colin.king@canonical.com \
--cc=hare@suse.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=osandov@fb.com \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox