* [PATCH] arm64: dts: qcom: sm8450: Add missing interconnects to serial
@ 2024-01-16 12:25 Konrad Dybcio
2024-01-16 12:53 ` Krzysztof Kozlowski
2024-01-28 2:17 ` Bjorn Andersson
0 siblings, 2 replies; 3+ messages in thread
From: Konrad Dybcio @ 2024-01-16 12:25 UTC (permalink / raw)
To: Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Vinod Koul, Dmitry Baryshkov
Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel,
Krzysztof Kozlowski, Georgi Djakov, Konrad Dybcio
The serial ports did not have their interconnect paths specified when
they were first introduced. Fix that.
Fixes: 5188049c9b36 ("arm64: dts: qcom: Add base SM8450 DTSI")
Fixes: f5837418479a ("arm64: dts: qcom: sm8450: add uart20 node")
Reported-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Suggested-by: Georgi Djakov <djakov@kernel.org>
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8450.dtsi | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
index 01e4dfc4babd..06f183ef8c78 100644
--- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
@@ -1028,6 +1028,12 @@ uart20: serial@894000 {
pinctrl-names = "default";
pinctrl-0 = <&qup_uart20_default>;
interrupts = <GIC_SPI 587 IRQ_TYPE_LEVEL_HIGH>;
+ interconnects = <&clk_virt MASTER_QUP_CORE_2 QCOM_ICC_TAG_ALWAYS
+ &clk_virt SLAVE_QUP_CORE_2 QCOM_ICC_TAG_ALWAYS>,
+ <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ALWAYS
+ &config_noc SLAVE_QUP_2 QCOM_ICC_TAG_ALWAYS>;
+ interconnect-names = "qup-core",
+ "qup-config";
status = "disabled";
};
@@ -1420,6 +1426,12 @@ uart7: serial@99c000 {
pinctrl-names = "default";
pinctrl-0 = <&qup_uart7_tx>, <&qup_uart7_rx>;
interrupts = <GIC_SPI 608 IRQ_TYPE_LEVEL_HIGH>;
+ interconnects = <&clk_virt MASTER_QUP_CORE_2 QCOM_ICC_TAG_ALWAYS
+ &clk_virt SLAVE_QUP_CORE_2 QCOM_ICC_TAG_ALWAYS>,
+ <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ALWAYS
+ &config_noc SLAVE_QUP_2 QCOM_ICC_TAG_ALWAYS>;
+ interconnect-names = "qup-core",
+ "qup-config";
status = "disabled";
};
};
---
base-commit: 8d04a7e2ee3fd6aabb8096b00c64db0d735bc874
change-id: 20240116-topic-8450serial-402fcb5e211b
Best regards,
--
Konrad Dybcio <konrad.dybcio@linaro.org>
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: qcom: sm8450: Add missing interconnects to serial
2024-01-16 12:25 [PATCH] arm64: dts: qcom: sm8450: Add missing interconnects to serial Konrad Dybcio
@ 2024-01-16 12:53 ` Krzysztof Kozlowski
2024-01-28 2:17 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2024-01-16 12:53 UTC (permalink / raw)
To: Konrad Dybcio, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Vinod Koul, Dmitry Baryshkov
Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel,
Georgi Djakov
On 16/01/2024 13:25, Konrad Dybcio wrote:
> The serial ports did not have their interconnect paths specified when
> they were first introduced. Fix that.
>
> Fixes: 5188049c9b36 ("arm64: dts: qcom: Add base SM8450 DTSI")
> Fixes: f5837418479a ("arm64: dts: qcom: sm8450: add uart20 node")
> Reported-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Suggested-by: Georgi Djakov <djakov@kernel.org>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Tested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: qcom: sm8450: Add missing interconnects to serial
2024-01-16 12:25 [PATCH] arm64: dts: qcom: sm8450: Add missing interconnects to serial Konrad Dybcio
2024-01-16 12:53 ` Krzysztof Kozlowski
@ 2024-01-28 2:17 ` Bjorn Andersson
1 sibling, 0 replies; 3+ messages in thread
From: Bjorn Andersson @ 2024-01-28 2:17 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Vinod Koul,
Dmitry Baryshkov, Konrad Dybcio
Cc: Konrad Dybcio, linux-arm-msm, devicetree, linux-kernel,
Krzysztof Kozlowski, Georgi Djakov
On Tue, 16 Jan 2024 13:25:44 +0100, Konrad Dybcio wrote:
> The serial ports did not have their interconnect paths specified when
> they were first introduced. Fix that.
>
>
Applied, thanks!
[1/1] arm64: dts: qcom: sm8450: Add missing interconnects to serial
commit: 6e115b75b43bd12d4061e53c8ff175e387783d8a
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-28 2:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-16 12:25 [PATCH] arm64: dts: qcom: sm8450: Add missing interconnects to serial Konrad Dybcio
2024-01-16 12:53 ` Krzysztof Kozlowski
2024-01-28 2:17 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).