Re: Cosmetic JFFS patch.

Linus Torvalds
2001-06-27T22:18:21Z

On Wed, 27 Jun 2001, Alan Cox wrote:

> > I find printk's with copyright notices quite disturbing. You will notice
> > that I don't have any myself. I think the whole thing is very tasteless,
> > and the "polite reminder" is just complete crap.
>
> If someone took all references to your name out of the kernel and put it out
> as 'Foobaros' by Foobarco you might take a different view.

I don't _have_ any instances of my name being printed out to annoy the
user, so that's a very theoretical argument.

> Intentionally or otherwise in the change thats what the JFFS argument is about.

This is my current patch in my tree. I refuse to have bickering in
printk's. You can edit the comment all you want.

Linus

-----
diff -urN v2.4.5/linux/fs/jffs/inode-v23.c linux/fs/jffs/inode-v23.c
--- v2.4.5/linux/fs/jffs/inode-v23.c Sun May 20 11:35:00 2001
+++ linux/fs/jffs/inode-v23.c Wed Jun 27 13:51:50 2001
@@ -16,6 +16,7 @@
* Ported to Linux 2.3.x and MTD:
* Copyright (C) 2000 Alexander Larsson (alex@cendio.se), Cendio Systems AB
*
+ * Copyright 2000, 2001 Red Hat, Inc.
*/

/* inode.c -- Contains the code that is called from the VFS. */
@@ -1719,9 +1720,6 @@
static int __init
init_jffs_fs(void)
{
- printk("JFFS version "
- JFFS_VERSION_STRING
- ", (C) 1999, 2000 Axis Communications AB\n");
return register_filesystem(&jffs_fs_type);
}