From: Michael Walle <mwalle@kernel.org>
To: Dave Airlie <airlied@gmail.com>
Cc: Inki Dae <daeinki@gmail.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Robert Foss <rfoss@kernel.org>,
Frieder Schrempf <frieder.schrempf@kontron.de>,
Jagan Teki <jagan@amarulasolutions.com>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Tim Harvey <tharvey@gateworks.com>,
Alexander Stein <alexander.stein@ew.tq-group.com>,
linux-kernel@vger.kernel.org,
DRI mailing list <dri-devel@lists.freedesktop.org>,
Daniel Vetter <daniel@ffwll.ch>,
Michael Trimarchi <michael@amarulasolutions.com>,
Dario Binacchi <dario.binacchi@amarulasolutions.com>,
Dmitry Osipenko <dmitry.osipenko@collabora.com>
Subject: Re: [PATCH] drm: bridge: samsung-dsim: Don't use FORCE_STOP_STATE
Date: Mon, 29 Jan 2024 11:39:20 +0100 [thread overview]
Message-ID: <795e2da5ae251321279920ee57c3d033@kernel.org> (raw)
In-Reply-To: <b18d88302acfca001a6693d78909bc2a@kernel.org>
> Also merge commit 663a907e199b (Merge remote-tracking branch
> 'drm-misc/drm-misc-next' into drm-tip) is broken because it
> completely removes samsung_dsim_atomic_disable(). Dunno whats
> going on there.
Actually, that merge commit looks even worse. It somehow folds
the original samsung_dsim_atomic_disable() into
samsung_dsim_atomic_enable(). Therefore, now the enable op
will clear the DSIM_STATE_VIDOUT_AVAILABLE flag?! It will also
never be set. Dunno how to proceed here.
-michael
next prev parent reply other threads:[~2024-01-29 10:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 16:43 [PATCH] drm: bridge: samsung-dsim: Don't use FORCE_STOP_STATE Michael Walle
2023-11-14 7:15 ` Alexander Stein
2023-11-14 8:52 ` Michael Walle
2023-11-14 14:29 ` Frieder Schrempf
2023-11-14 15:53 ` Michael Walle
2023-12-01 9:04 ` Michael Walle
2023-12-18 11:24 ` Frieder Schrempf
[not found] ` <CAAQKjZMccDwa63_PNJCP0rNOaHjTwcOz8AbKa=JXLQi-b0QVVw@mail.gmail.com>
2024-01-09 8:47 ` Michael Walle
2024-01-09 12:50 ` Daniel Vetter
[not found] ` <CAAQKjZNnJQDn_r1+WNmsxM-2O48O0+yWAUAqpjZRjMYMT3xGwg@mail.gmail.com>
2024-01-26 18:28 ` Dave Airlie
2024-01-29 9:20 ` Frieder Schrempf
2024-01-29 16:51 ` Frieder Schrempf
2024-01-29 10:32 ` Michael Walle
2024-01-29 10:39 ` Michael Walle [this message]
2024-01-29 16:06 ` Michael Walle
2024-01-30 9:11 ` Dario Binacchi
2024-01-30 9:24 ` Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=795e2da5ae251321279920ee57c3d033@kernel.org \
--to=mwalle@kernel.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=andrzej.hajda@intel.com \
--cc=daeinki@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dario.binacchi@amarulasolutions.com \
--cc=dmitry.osipenko@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=frieder.schrempf@kontron.de \
--cc=jagan@amarulasolutions.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=michael@amarulasolutions.com \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox