From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754646Ab1LMAbK (ORCPT ); Mon, 12 Dec 2011 19:31:10 -0500 Received: from ozlabs.org ([203.10.76.45]:44992 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753472Ab1LMAbF (ORCPT ); Mon, 12 Dec 2011 19:31:05 -0500 From: Michael Neuling To: Paul Gortmaker cc: Alan Cox , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, sfr@canb.auug.org.au, linux-next@vger.kernel.org, Steven Rostedt , Michal Marek X-GPG-Fingerprint: 9B25 DC2A C58D 2C8D 47C2 457E 0887 E86F 32E6 BE16 X-GPG-Fingerprint: 9365 87D7 A7EF 4721 420B 91D9 CD5B 874B EAC1 B3F5 MIME-Version: 1.0 Subject: [PATCH] serial: fix Kconfig for Freescale 16550 X-Mailer: MH-E 8.2; nmh 1.3; GNU Emacs 23.3.1 Date: Tue, 13 Dec 2011 11:31:03 +1100 Message-ID: <7963.1323736263@neuling.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org next-20111212 breaks with linking a pmac32_defconfig with: drivers/built-in.o: In function `fsl8250_handle_irq': (.text+0x7ba74): undefined reference to `serial8250_modem_status' drivers/built-in.o: In function `fsl8250_handle_irq': (.text+0x7baa4): undefined reference to `serial8250_tx_chars' drivers/built-in.o: In function `fsl8250_handle_irq': (.text+0x7bab4): undefined reference to `serial8250_rx_chars' Caused by: 9deaa53 serial: add irq handler for Freescale 16550 errata. pmac32_defconfig results in SERIAL_8250_FSL=y but SERIAL_8250=m so 8250_fsl.c doesn't link properly. This explicitly makes SERIAL_8250_FSL depends on SERIAL_8250=y. Signed-off-by: Michael Neuling --- I'm not sure this is the right fix as it seems like a Kconfig bug. diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig index a1d55c3..c9046de 100644 --- a/drivers/tty/serial/Kconfig +++ b/drivers/tty/serial/Kconfig @@ -99,7 +99,7 @@ config SERIAL_8250_PNP config SERIAL_8250_FSL bool - depends on SERIAL_8250 && PPC + depends on SERIAL_8250=y && PPC default PPC config SERIAL_8250_HP300