From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932091AbcELIj0 (ORCPT ); Thu, 12 May 2016 04:39:26 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:47907 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751512AbcELIjY (ORCPT ); Thu, 12 May 2016 04:39:24 -0400 From: Markus Pargmann To: "Pranay Kr. Srivastava" Cc: nbd-general@lists.sourceforge.net, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org Subject: Re: [PATCH v4 07/18] nbd: fix checkpatch split string warning. Date: Thu, 12 May 2016 10:39:13 +0200 Message-ID: <7973954.3TU6ugLbvt@adelgunde> User-Agent: KMail/4.14.1 (Linux/4.5.0-0.bpo.1-amd64; KDE/4.14.2; x86_64; ; ) In-Reply-To: <1462954726-11825-8-git-send-email-pranjas@gmail.com> References: <1462954726-11825-1-git-send-email-pranjas@gmail.com> <1462954726-11825-8-git-send-email-pranjas@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart13085515.Noyuh75TRU"; micalg="pgp-sha256"; protocol="application/pgp-signature" X-SA-Exim-Connect-IP: 2001:67c:670:100:a61f:72ff:fe68:75ba X-SA-Exim-Mail-From: mpa@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nextPart13085515.Noyuh75TRU Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="us-ascii" Hi, On Wednesday 11 May 2016 11:18:35 Pranay Kr. Srivastava wrote: > Signed-off-by: Pranay Kr. Srivastava > --- > drivers/block/nbd.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c > index 6a4dc3a..7a5b8ef 100644 > --- a/drivers/block/nbd.c > +++ b/drivers/block/nbd.c > @@ -587,8 +587,7 @@ static int nbd_thread_send(void *data) > =09=09=09=09nbd_send_req(nbd, &sreq); > =09=09=09=09mutex_unlock(&nbd->tx_lock); > =09=09=09=09dev_err(disk_to_dev(nbd->disk), > -=09=09=09=09=09"Device Timeout occured.Shutting down" > -=09=09=09=09=09" socket."); > +=09=09=09=09"Device Timeout occured.Shutting down socket."); Please keep the indentation to the opening bracket here. Shouldn't this= create a checkpatch warning as well? Regards, Markus > =09=09=09} > =09=09=09mutex_unlock(&nbd->sock_lock); > =09=09=09sock_shutdown(nbd); >=20 =2D-=20 Pengutronix e.K. | = | Industrial Linux Solutions | http://www.pengutronix.de/= | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 = | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-555= 5 | --nextPart13085515.Noyuh75TRU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJXNEE3AAoJEEpcgKtcEGQQjiwP/iwRFUGKzOhb1U0W5Hb5G4UR ck+D+UXYtLIlLA27Crq6dtTJmMAg3QWaE42X2/JnPWv+rCWybBdt1H0seaZKAYm3 pvMBEx4AqWjCQ8AKAhtOyD3YltDxx2Y3Yy9eyyHNkyV+C8np082CuzkQ/SfO7Nb8 eZpAj37ZsSgV5zFFCFjW5ZjHNUDkrGDKRc9trGAI34dQ/Z+HAft7Mlg78NHSOsKS eDjrnyvEzsAOild22cEPTqrd3eN1j/BEK8FvTROV9gr66pBR3rCkx4lBxtXQGWfg hh7t3RpQ5dqCIqw1CZJsJTBpRb4YDH6Vv/2of7KMeSE8/069RmDCbSD1IpmmrojS 8RDh7jXFgMNoK84BB1K79dPGpzbi/w7qFRR1pZiuzBfEEATbeSMDB0FiZtga5wfn 5H1926ubSSr1upRUjSYhPpcUMLKwe5fV2f1H/VJb0DQefkF3Nf0Gxmmde+WdTg2t 7QBa0Px/r0PvTfokqUgRUVNcEW99XQuOrXKmyY41fDZA2NZCn+6PSoTke+P+2/Ky vqYyRnswUH4t8IZ0cSBEgVcZZAev5TOk/F0CdqqGlhJhZrVBfUERyOLIGRrQUzQb wMOuwmLO2A4MXXzLXckpwN+dcXV8olIyHlsoEgpxW0xhvzs4nc2uG1v6BnLq1YDw IJtkyLRogTUTvPo1GoqF =IMjN -----END PGP SIGNATURE----- --nextPart13085515.Noyuh75TRU--