From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6134D16630F for ; Wed, 26 Jun 2024 08:30:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719390608; cv=none; b=OEi+Fl/1zDzBn/JsIjHmlH9TPQD0T3qWaZ2ZVf2Anz0VsBenyFECKz/sHEk72artV4BPmNfsJLTkSdTgBXZpTJDearjyQS3/NhET5k4TtCqa7QCqL8jMftsDSf8kD/4Qx/wueiZ4mhm7dYOgAmLCDqpyaYeCCZbewJePMERe964= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719390608; c=relaxed/simple; bh=QeqkQtniBpxvd+UitRjWWYVFy5iXjPy7xv5fji8+3L8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DwdgWmjsXBfiImJSrN40/5McV2jmT16M9yOGMOLeXQyhwB6d9SYNOqJaCOdMovdY579XcukeiIbnye7vLyrNKTJQ2PL+dDFdkzjWcZq3sQ5OlIXN+x1vLDVk67jYG4sX99Q4+uJMZX6ylILZdGyl5buB1orsq8Zmkro+Tp1f/0s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=dud3sBF2; arc=none smtp.client-ip=209.85.167.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="dud3sBF2" Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-52cd6784aa4so5675779e87.3 for ; Wed, 26 Jun 2024 01:30:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1719390603; x=1719995403; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yyQdICgaO84yFawHrHyVyr2QToU/+XJGR839rOrXaR0=; b=dud3sBF2tVPRThcYciFuClucski/fMejwvP58nN7PA2C4550Bo1BWAmdARVLHwVjwE iG/VckS1SBkJmwhbUhUdrTvAXJa+qUkiUvwTUbwY7JDSg6nlUbhVGjV0lzJQfSBsWl7t AJbsBQHNfkMxtODpUfkOdbbmC5LdHOE2YbM/1zX9IQm+GjXcAzEnR1Z7KPWP516s9y35 SWqG/skTT6LKFroJwByr0mw4jxtc5bvFQL2GWGqMKF6U4LBQLf7fwKM9+PjfzENn0O9+ m1wQXj+ZuAtRrWRqMYubFa0aj+njwlJO76nffH00lHmh2ntyx6AAOpjQdprKcvep0tCW AKhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719390603; x=1719995403; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yyQdICgaO84yFawHrHyVyr2QToU/+XJGR839rOrXaR0=; b=K9OPY7sxtNqiN5CMWcY6SoCP530IHNFKSTA5ekfIYto9hXOhJ8LDB/j43/EHD5mbTq bKLj1c0YnQczpOBZpZo5g9KfupgiZ1QUuJ61oBXmCObLlNlpTysgiBKPbEtaiSUEIEfN kDps9/h8A/uoUIxW8Nl4/HTBsOHoAv1286ZnaivrlADxV9tpn4IORe5cs729JgpLmOup nbb9EnWTby2YyhFu64547sTf+9PxpZa+X+R35K0G67l/2qy9lWY6a6pfak2mYYVjneZX sLVRbnT+OM+XTCZVr81xGstvSoWE43yREBSWiViPMPCN34Q8CfdSpZTGQI4wuaUtq1Wy DBuw== X-Forwarded-Encrypted: i=1; AJvYcCXDAPN/4IDsn16n0s4GGsXrQFGKCkQ8ZWEf2jDP8KPhq44HiJCM4QXkvhD8NNvHmJWZBrWXkJuWGI3N1Br6iRZbmQ2MDcn6Pd43x5Hv X-Gm-Message-State: AOJu0YznrQzL0tnnpP8Qo1lTHupJ6Fiumze5h7IRvlsDm9mKshoHTu6g uTyX37Nd3RY6bBV/P8dHKZMPnSSiRzzkda16EIzB37MPptSieSCSGu7LDVmd6IQ= X-Google-Smtp-Source: AGHT+IEca5cJU5ZW212x9C2okoEwkWZvRgPivrrUuJX0Y9+4JhwZuZye4d1Yr/SDCtFZrF/eM34AgA== X-Received: by 2002:a05:6512:607:b0:52c:d84b:93b2 with SMTP id 2adb3069b0e04-52ce18341f9mr5698467e87.15.1719390603394; Wed, 26 Jun 2024 01:30:03 -0700 (PDT) Received: from [192.168.1.172] ([93.5.22.158]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-424c84245f0sm16687705e9.33.2024.06.26.01.30.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Jun 2024 01:30:03 -0700 (PDT) Message-ID: <79811fff-4fdf-4121-9cea-6ed7e1329dad@baylibre.com> Date: Wed, 26 Jun 2024 10:30:01 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 03/16] dt-bindings: mfd: mediatek: Add codec property for MT6357 PMIC To: Krzysztof Kozlowski , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Lee Jones , Flora Fu , Jaroslav Kysela , Takashi Iwai , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , Catalin Marinas , Will Deacon , Rob Herring , Krzysztof Kozlowski Cc: linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org References: <20240226-audio-i350-v6-0-f754ec1a7634@baylibre.com> <20240226-audio-i350-v6-3-f754ec1a7634@baylibre.com> <95bab90f-b196-4e79-bb88-7fd534cca721@baylibre.com> <5c9ab5bf-95f2-4195-8797-335010223aac@kernel.org> Content-Language: en-US From: Alexandre Mergnat In-Reply-To: <5c9ab5bf-95f2-4195-8797-335010223aac@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 25/06/2024 15:44, Krzysztof Kozlowski wrote: > On 25/06/2024 11:23, Alexandre Mergnat wrote: >> >> >> On 21/06/2024 17:00, Krzysztof Kozlowski wrote: >>> On 19/06/2024 16:46, Alexandre Mergnat wrote: >>>> Add the audio codec sub-device. This sub-device is used to set the >>>> optional voltage values according to the hardware. >>>> The properties are: >>>> - Setup of microphone bias voltage. >>>> - Setup of the speaker pin pull-down. >>>> >>>> Also, add the audio power supply property which is dedicated for >>>> the audio codec sub-device. >>>> >>>> Signed-off-by: Alexandre Mergnat >>>> --- >>>> .../devicetree/bindings/mfd/mediatek,mt6357.yaml | 33 ++++++++++++++++++++++ >>>> 1 file changed, 33 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt6357.yaml b/Documentation/devicetree/bindings/mfd/mediatek,mt6357.yaml >>>> index 37423c2e0fdf..d95307393e75 100644 >>>> --- a/Documentation/devicetree/bindings/mfd/mediatek,mt6357.yaml >>>> +++ b/Documentation/devicetree/bindings/mfd/mediatek,mt6357.yaml >>>> @@ -37,6 +37,32 @@ properties: >>>> "#interrupt-cells": >>>> const: 2 >>>> >>>> + vaud28-supply: >>>> + description: 2.8 volt supply phandle for the audio codec >>>> + >>>> + audio-codec: >>>> + type: object >>> Still not much improved. You do not have any resources there, so these >>> should go to the parent node. >> >> Hi Krzysztof, >> >> vaud28-supply seems to be a mistake that I forward port. >> In the V4, AFAII, your feedback [1] suggested me to move the vaud28-supply from the "audio-codec" >> sub-node to the parent node, which for me is the "pmic" (mfd), because the property is considered as >> power-supply. >> >> pwrap { >> pmic { >> ... >> audio-codec { >> ... >> >> Hardware side, vaud28-supply is the output of PMIC-regulator subsystem, and AVDD28 is the input of >> PMIC-audio-codec subsystem. Then: >> - The property name is wrong and must be change to AVDD28, which is a consumer (power input), not a >> power-supply. => description: 2.8 volt power input for microphones (AU_VIN0, AU_VIN1, AU_VIN2) >> - IMHO, move this property to the next parent (pwrap) isn't consistent. It should be moved back to >> Documentation/devicetree/bindings/mfd/mediatek,mt6357.yaml (Done in the V4) into audio-codec >> substystem, beside mediatek,micbias0-microvolt > > I don't understand why do we talk again about supply. My comment was not > under the supply. Because your word are: " And now you should see how odd it looks. Supplies are part of entire chip, not subblock, even if they supply dedicated domain within that chip. That's why I asked to put it in the parent node. " My bad, I forgot to link you the old message in my previous answer [1] [1] https://lore.kernel.org/all/6d21da37-8be7-467c-8878-d57af0b0201b@kernel.org/#t -- Regards, Alexandre