From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1583E7C4EB for ; Wed, 4 Oct 2023 18:37:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244318AbjJDSh7 (ORCPT ); Wed, 4 Oct 2023 14:37:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233552AbjJDSh5 (ORCPT ); Wed, 4 Oct 2023 14:37:57 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FEB6DD; Wed, 4 Oct 2023 11:37:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696444673; x=1727980673; h=message-id:subject:from:to:cc:date:in-reply-to: references:content-transfer-encoding:mime-version; bh=DpVXv4bi27kbwhcFtKiltzdEWNLjeqF8vKmHb71bbO8=; b=LTQbCcyv84P+F5JBseUGtauxYe7ACRUL1641sO+cgY+taiTWED+oUd6r dlsN1pQ56Ff24MRXb5NTH0O3dGBwdpqHMAG1SHypagep0wKFI7q+0L00h lqWGzTGQIIkikQbakQpZhzSaNxbcK5WGGDusAZh3O+LdeusAxBMvelt+o fBO2PzoQOe4iPp/KvIKTYrCBiPwKQ8PJcWgUm0IpheyagQiG0oYuD7s0A 0/q6GUB5IXNvlElx1JrNVSksmNbaDH5bdVPBbUNDlv96j8HoBByTHVv66 Ksvc47LWxsh+Ih3wylVeBqT3gQMox9lUjvbFsoIZE2niFCSNUlwKsloLZ g==; X-IronPort-AV: E=McAfee;i="6600,9927,10853"; a="386091281" X-IronPort-AV: E=Sophos;i="6.03,201,1694761200"; d="scan'208";a="386091281" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2023 11:37:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10853"; a="745094397" X-IronPort-AV: E=Sophos;i="6.03,201,1694761200"; d="scan'208";a="745094397" Received: from spandruv-desk1.amr.corp.intel.com ([10.209.86.10]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2023 11:37:52 -0700 Message-ID: <798686123b656dcd0907851160ea1a26506750d1.camel@linux.intel.com> Subject: Re: [PATCH v2 1/3] platform/x86/intel/tpmi: Add defines to get version information From: srinivas pandruvada To: Andy Shevchenko Cc: hdegoede@redhat.com, markgross@kernel.org, ilpo.jarvinen@linux.intel.com, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 04 Oct 2023 11:37:45 -0700 In-Reply-To: References: <20231003184916.1860084-1-srinivas.pandruvada@linux.intel.com> <20231003184916.1860084-2-srinivas.pandruvada@linux.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2023-10-04 at 15:59 +0300, Andy Shevchenko wrote: > On Tue, Oct 03, 2023 at 11:49:14AM -0700, Srinivas Pandruvada wrote: > > Add defines to get major and minor version from a TPMI version > > field > > value. This will avoid code duplication to convert in every feature > > driver. Also add define for invalid version field. >=20 > ... >=20 > > +#define TPMI_VERSION_INVALID=C2=A0=C2=A0=C2=A00xff >=20 > I would make it clearer with (GENMASK(7, 5) | GENMASK(4, 0)) > or even with specific masks defined and used in both cases: > #def >=20 > #define TPMI_MINVER_MASK=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0G= ENMASK(4, 0) > #define TPMI_MAJVER_MASK=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0G= ENMASK(7, 5) >=20 > #define TPMI_VERSION_INVALID=C2=A0=C2=A0=C2=A0=C2=A0(TPMI_MINVER_MASK | T= PMI_MAJVER_MASK) >=20 > #define TPMI_MINOR_VERSION(val)=C2=A0FIELD_GET(TPMI_MINVER_MASK, val) > #define TPMI_MAJOR_VERSION(val)=C2=A0FIELD_GET(TPMI_MAJVER_MASK, val) >=20 > > +#define TPMI_MINOR_VERSION(val)=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0FIELD_GET(GENMASK(4, 0), > > val) > > +#define TPMI_MAJOR_VERSION(val)=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0FIELD_GET(GENMASK(7, 5), > > val) OK. Will add another patch on top. Thanks, Srinivas >=20