Re: [PATCH 1/4] mm: pass set_count and set_reserved to __init_single_page

Matthew Wilcox
2023-09-22T07:47:39Z

On Fri, Sep 22, 2023 at 03:09:20PM +0800, Yajun Deng wrote:
> - __init_single_page(page, pfn, zone, nid);
> + __init_single_page(page, pfn, zone, nid, true, false);

So Linus has just had a big rant about not doing bool flags to
functions. And in particular _multiple_ bool flags to functions.

ie this should be:

#define INIT_PAGE_COUNT (1 << 0)
#define INIT_PAGE_RESERVED (1 << 1)

__init_single_page(page, pfn, zone, nid, INIT_PAGE_COUNT);

or something similar.

I have no judgement on the merits of this patch so far. Do you have
performance numbers for each of these patches? Some of them seem quite
unlikely to actually help, at least on a machine which is constrained
by cacheline fetches.