2.6.10-ac3 compile failure

2.6.10-ac3 compile failure

[Eyal Lebedinsky]

   CC [M]  drivers/char/agp/intel-agp.o
drivers/char/agp/intel-agp.c: In function `intel_i915_configure':
drivers/char/agp/intel-agp.c:640: error: too many arguments to function `writel'
make[3]: *** [drivers/char/agp/intel-agp.o] Error 1

FYI

-- 
Eyal Lebedinsky (eyal@eyal.emu.id.au) <http://samba.org/eyal/>
	If attaching .zip rename to .dat

Re: 2.6.10-ac3 compile failure

[Adam Mercer]

[-- Attachment #1: Type: text/plain, Size: 377 bytes --]

On Wed, 05 Jan 2005 11:39:15 +1100, Eyal Lebedinsky <eyal@eyal.emu.id.au> wrote:
>    CC [M]  drivers/char/agp/intel-agp.o
> drivers/char/agp/intel-agp.c: In function `intel_i915_configure':
> drivers/char/agp/intel-agp.c:640: error: too many arguments to function `writel'
> make[3]: *** [drivers/char/agp/intel-agp.o] Error 1

Applying this patch worked for me

Cheers

Adam

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: intel-agp-2.6.10-ac3.patch --]
[-- Type: text/x-patch; name="intel-agp-2.6.10-ac3.patch", Size: 612 bytes --]

--- drivers/char/agp/intel-agp.c-orig	2005-01-04 19:59:59.000000000 +0000
+++ drivers/char/agp/intel-agp.c	2005-01-04 19:50:56.000000000 +0000
@@ -637,7 +637,7 @@
 	gmch_ctrl |= I830_GMCH_ENABLED;
 	pci_write_config_word(agp_bridge->dev,I830_GMCH_CTRL,gmch_ctrl);
 
-	writel(agp_bridge->gatt_bus_addr | I810_PGETBL_ENABLED, intel_i830_private.registers,I810_PGETBL_CTL);
+	writel(agp_bridge->gatt_bus_addr | I810_PGETBL_ENABLED, intel_i830_private.registers+I810_PGETBL_CTL);
 	readl(intel_i830_private.registers+I810_PGETBL_CTL);	/* PCI Posting. */
 	
 	if (agp_bridge->driver->needs_scratch_page) {

Re: 2.6.10-ac3 compile failure

[Alan Cox]

On Mer, 2005-01-05 at 00:39, Eyal Lebedinsky wrote:
>    CC [M]  drivers/char/agp/intel-agp.o
> drivers/char/agp/intel-agp.c: In function `intel_i915_configure':
> drivers/char/agp/intel-agp.c:640: error: too many arguments to function `writel'
> make[3]: *** [drivers/char/agp/intel-agp.o] Error 1

Already fixed in -ac4. Its one reason -ac3 wasnt publically announced. I
figured I'd get enough mail as it was with that error 

Re: 2.6.10-ac3 compile failure

[Cal Peake]

On Thu, 6 Jan 2005, Alan Cox wrote:

> Already fixed in -ac4. Its one reason -ac3 wasnt publically announced. I
> figured I'd get enough mail as it was with that error 

Was -ac4 ever announced? Couldn't find it in the archives and it'd be nice 
to have a changelog :)

-- Cal