From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1762422AbcALOAe (ORCPT <rfc822;w@1wt.eu>);
	Tue, 12 Jan 2016 09:00:34 -0500
Received: from mout.kundenserver.de ([212.227.126.187]:59454 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1762405AbcALOAc (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 12 Jan 2016 09:00:32 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: andy.gross@linaro.org, linux-arm-msm@vger.kernel.org,
        Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] arm64: dts: apq8016-sbc: add regulators support
Date: Tue, 12 Jan 2016 14:59:55 +0100
Message-ID: <7998607.BblzgPxGPW@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <1452606392-24614-1-git-send-email-srinivas.kandagatla@linaro.org>
References: <1452606358-24569-1-git-send-email-srinivas.kandagatla@linaro.org> <1452606392-24614-1-git-send-email-srinivas.kandagatla@linaro.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:2lZ6YB/6Hsytz4hm/pndTjpcLrgzPB3lf4RevuR1Ew0e0C3U3On
 QvJgiz7XcLIgnMKGZk1CR9bUFkhWqjCRAy19+6w2HX8kS9S8e24zgpVy9P7VDlDOKzhOEat
 XpL0/Yyq02nm9HDIgxRDOU68LBqLLXbVrKzNC6V7j654FgC/xRLeEkFpFwWLh3n4NgJ4Pmk
 5AKRDpeTThSkqwFeyrmGg==
X-UI-Out-Filterresults: notjunk:1;V01:K0:vjPNZPnS2V4=:tIs+yN0jjJl2isdNHc6gI4
 EZ6gieTAmOaj4wClCQ8iEGAmLK1P63zhL+xf3yeCAPNMLXQLGiThbODCBwQkpaOHpBB/FTvAh
 r5w8EGVkzFLhrhUrWz0UGhRqp0YZ7MRnMf66CMAeZ4354MeabT1dFIKjuKXEPyoX7r+N3ywIZ
 fZXGCTRegGoOnRH54xuH93Br4KPb+0AJC3GRib5HFE4jwhoruciWTwnRRfPgikKNWxdQo+gSo
 0SF/3oMEwfTBXS9yzjX2vfXT4zC81DXkNi7zqdj8/gi+kSnUr3UnlWhaDCHAqjkJdZMLZMDBp
 q2M03Hx6fT2kPCi9OVP7CXBJL6L7WlJfDJ/D6Abgjz5fZGKpkXguyPh7S6w5qKkK2gBDq/ICn
 lwPabhE9LHkcNaUGTSCLMB3Wx0Nr3OYXUBALI8f+yuqcacuvBkHE9F7h0Oja5Nh7rtRSPrJYw
 asG1RKWFWfhlxWzctubzAw+ljrv1mS5Y0ShPakj3TN/rcwomZ4Ijao7KP09y6IVcAuK1tsXv+
 RBN4LuYZLXPh1KnSa+vhbHOKDew+ZP7hDZhYe9ppi9xkFZdDGd51qHlVpzzifugvmUV/ItWeS
 gLdNvkJz5XWenkUrwR7oE61jZBEtFEUK/9AzzxmupBBWJJgmDfb5WIL0i6DOzFCMOeGllJAth
 G524Q5vaJZXkvnMHkdEPaMbb7AVdTWZn+BKmeKiBklrRz7WbihlKeejSXaFblEh64KOnTGisZ
 WcWEaJAKU6GgasL8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday 12 January 2016 13:46:32 Srinivas Kandagatla wrote:
>         };
>  
> +       smd {
> +               rpm {
> +                       rpm-requests {
> +                               pm8916-regulators {
> +
> +                                       vdd_l1_l2_l3-supply = <&pm8916_s3>;
> +                                       vdd_l5-supply = <&pm8916_s3>;
> +                                       vdd_l4_l5_l6-supply = <&pm8916_s4>;
> +                                       vdd_l7-supply = <&pm8916_s4>;
> +
> 

If you're nested this deeply, you should consider using labels, e.g.

/ {
       ...

       smd {
               rpm {
                      rpm-requests {
                               regulators: pm8916-regulators {

				};
			};
		};
	};

	...
};


&regulators {
        vdd_l1_l2_l3-supply = <&pm8916_s3>;
        vdd_l5-supply = <&pm8916_s3>;
        vdd_l4_l5_l6-supply = <&pm8916_s4>;
        vdd_l7-supply = <&pm8916_s4>;

	s1 {
                 regulator-min-microvolt = <375000>;
                 regulator-max-microvolt = <1562000>;
	};

        s3 {
	        regulator-min-microvolt = <375000>;
	        regulator-max-microvolt = <1562000>;
        };

	...
};

btw, it seems odd to me that all those nodes under 'smd'
have names but no addresses.

	Arnd