public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Chris Mason <mason@suse.com>
To: Andrew Morton <akpm@zip.com.au>, "Stephen C. Tweedie" <sct@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] 2.4.x write barriers (updated for ext3)
Date: Thu, 21 Feb 2002 18:30:20 -0500	[thread overview]
Message-ID: <799880000.1014334220@tiny> (raw)


Hi everyone,

I've changed the write barrier code around a little so the block layer 
isn't forced to fail barrier requests the queue can't handle.

This makes it much easier to add support for ide writeback
flushing to things like ext3 and lvm, where I want to make
the minimal possible changes to make things safe.

The full patch is at:
ftp.suse.com/pub/people/mason/patches/2.4.18/queue-barrier-8.diff

There might be additional spots in ext3 where ordering needs to be 
enforced, I've included the ext3 code below in hopes of getting 
some comments.

The only other change was to make reiserfs use the IDE flushing mode
by default.  It falls back to non-ordered calls on scsi.

-chris

--- linus.23/fs/jbd/commit.c Mon, 28 Jan 2002 09:51:50 -0500
+++ linus.23(w)/fs/jbd/commit.c Thu, 21 Feb 2002 17:11:00 -0500
@@ -595,7 +595,15 @@
                struct buffer_head *bh = jh2bh(descriptor);
                clear_bit(BH_Dirty, &bh->b_state);
                bh->b_end_io = journal_end_buffer_io_sync;
+
+               /* if we're on an ide device, setting BH_Ordered_Flush
+                  will force a write cache flush before and after the
+                  commit block.  Otherwise, it'll do nothing.  */
+
+               set_bit(BH_Ordered_Flush, &bh->b_state);
                submit_bh(WRITE, bh);
+               clear_bit(BH_Ordered_Flush, &bh->b_state);
+
                wait_on_buffer(bh);
                put_bh(bh);             /* One for getblk() */
                journal_unlock_journal_head(descriptor);









             reply	other threads:[~2002-02-21 23:31 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-02-21 23:30 Chris Mason [this message]
2002-02-22 14:19 ` [PATCH] 2.4.x write barriers (updated for ext3) Stephen C. Tweedie
2002-02-22 15:26   ` Chris Mason
  -- strict thread matches above, loose matches on Subject: below --
2002-02-22 15:57 James Bottomley
2002-02-22 16:10 ` Chris Mason
2002-02-22 16:13 ` Stephen C. Tweedie
2002-02-22 17:36   ` James Bottomley
2002-02-22 18:14     ` Chris Mason
2002-02-28 15:36       ` James Bottomley
2002-02-28 15:55         ` Chris Mason
2002-02-28 17:58           ` Mike Anderson
2002-02-28 18:12           ` Chris Mason
2002-03-01  2:08             ` James Bottomley
2002-03-03 22:11         ` Daniel Phillips
2002-03-04  3:34           ` Chris Mason
2002-03-04  5:05             ` Daniel Phillips
2002-03-04 15:03               ` James Bottomley
2002-03-04 17:04                 ` Stephen C. Tweedie
2002-03-04 17:16                   ` Chris Mason
2002-03-04 18:05                     ` Stephen C. Tweedie
2002-03-04 18:28                       ` James Bottomley
2002-03-04 19:55                         ` Stephen C. Tweedie
2002-03-04 19:48                       ` Daniel Phillips
2002-03-04 19:57                         ` Stephen C. Tweedie
2002-03-04 21:06                           ` Daniel Phillips
2002-03-05 14:58                             ` Stephen C. Tweedie
2002-03-05  7:48                         ` Jens Axboe
2002-03-04 19:51                     ` Daniel Phillips
2002-03-05  7:42                       ` Jens Axboe
2002-03-04 17:35                   ` James Bottomley
2002-03-04 17:48                     ` Chris Mason
2002-03-04 18:11                       ` James Bottomley
2002-03-04 18:41                         ` Chris Mason
2002-03-04 21:34                         ` Stephen C. Tweedie
2002-03-04 18:09                     ` Stephen C. Tweedie
2002-03-04  8:19             ` Helge Hafting
2002-03-04 14:57             ` James Bottomley
2002-03-04 17:24               ` Chris Mason
2002-03-04 19:02                 ` Daniel Phillips
2002-03-05  7:22               ` Jeremy Higdon
2002-03-05 23:01                 ` Daniel Phillips
2002-03-04  4:21           ` Jeremy Higdon
2002-03-04  5:31             ` Daniel Phillips
2002-03-04  6:09               ` Jeremy Higdon
2002-03-04  7:57                 ` Daniel Phillips
2002-03-05  7:09                   ` Jeremy Higdon
2002-03-05 22:56                     ` Daniel Phillips
2002-03-04 16:52                 ` Stephen C. Tweedie
2002-03-04 18:15                   ` Daniel Phillips
2002-03-05  7:40                     ` Jens Axboe
2002-03-05 22:29                       ` Daniel Phillips
2002-03-12  7:01                         ` Jens Axboe
2002-03-10  5:24                   ` Douglas Gilbert
2002-03-11 11:13                     ` Kurt Garloff
2002-03-12  1:17                       ` GOTO Masanori
2002-03-12  6:58                       ` Jens Axboe
2002-03-13 22:37                         ` Peter Osterlund
2002-03-11 11:34                     ` Stephen C. Tweedie
2002-03-11 17:15                       ` James Bottomley
2002-03-04 14:48           ` James Bottomley
2002-03-06 13:59             ` Daniel Phillips
2002-03-06 14:34               ` James Bottomley
2002-02-25 10:57 ` Helge Hafting
2002-02-25 15:04   ` James Bottomley
2002-03-01 15:26 Dieter Nützel
2002-03-01 16:00 ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=799880000.1014334220@tiny \
    --to=mason@suse.com \
    --cc=akpm@zip.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sct@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox