Re: [PATCH 2/2] arm64: dts: sc7180: Add minimal dts/dtsi files for SC7180 soc

[Taniya Das <tdas@codeaurora.org>]

>>>> +		xo_board: xo-board {
>>>> +			compatible = "fixed-clock";
>>>> +			clock-frequency = <38400000>;
>>>> +			clock-output-names = "xo_board";
>>>> +			#clock-cells = <0>;
>>>> +		};
>>>> +
>>>> +		sleep_clk: sleep-clk {
>>>> +			compatible = "fixed-clock";
>>>> +			clock-frequency = <32764>;
>>>> +			clock-output-names = "sleep_clk";
>>>> +			#clock-cells = <0>;
>>>> +		};
>>>> +
>>>> +		bi_tcxo: bi_tcxo {
>>>
>>> why is this a clock defined here? Isnt this gcc clock?
>>
>> This is a RPMH-controlled clock and not from GCC. It is the parent clock for
>> GCC RCGs/PLLs.
> 
> Yes right!
> 
>> Once the RPMH clock support is added these would be removed.
> 
> Wont it make sense to keep this bit not upstream and then remove that
> part when you have rpmh support available. Reduces the churn upstream!
> 
> The parent can be xo_board till then!
> 

The xo_board is 38.4MHz and bi_tcxo (xo/2), which needs to be updated 
anyways :).

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation.

--