From: <Claudiu.Beznea@microchip.com>
To: <krzysztof.kozlowski@linaro.org>
Cc: <robh+dt@kernel.org>, <alexandre.belloni@bootlin.com>,
<linux-kernel@vger.kernel.org>, <sboyd@kernel.org>,
<linux-clk@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<Nicolas.Ferre@microchip.com>,
<krzysztof.kozlowski+dt@linaro.org>, <Conor.Dooley@microchip.com>,
<mturquette@baylibre.com>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH v5 5/5] dt-bindings: clocks: at91sam9x5-sckc: convert to yaml
Date: Thu, 18 May 2023 08:31:48 +0000 [thread overview]
Message-ID: <79b77cb4-1e18-3c19-15dd-66951541abdf@microchip.com> (raw)
In-Reply-To: <20230517141508.evb6jg5bcpjzhqve@krzk-bin>
On 17.05.2023 17:15, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On Wed, 17 May 2023 12:41:19 +0300, Claudiu Beznea wrote:
>> Convert Atmel slow clock controller documentation to yaml.
>>
>> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>> .../devicetree/bindings/clock/at91-clock.txt | 30 --------
>> .../bindings/clock/atmel,at91sam9x5-sckc.yaml | 70 +++++++++++++++++++
>> 2 files changed, 70 insertions(+), 30 deletions(-)
>> delete mode 100644 Documentation/devicetree/bindings/clock/at91-clock.txt
>> create mode 100644 Documentation/devicetree/bindings/clock/atmel,at91sam9x5-sckc.yaml
>>
>
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
>
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
>
> Full log is available here: https://patchwork.ozlabs.org/patch/1782586
>
>
> sckc@fffffe50: '#clock-cells' is a required property
> arch/arm/boot/dts/at91sam9n12ek.dtb
>
> sckc@fffffe50: 'clocks' is a required property
> arch/arm/boot/dts/at91sam9n12ek.dtb
>
> sckc@fffffe50: 'slck', 'slow_osc', 'slow_rc_osc' do not match any of the regexes: 'pinctrl-[0-9]+'
> arch/arm/boot/dts/at91sam9n12ek.dtb
Is it possible that this has been checked on a wrong base? I'm asking this
because:
- patch 3/5 in this series uses proper bindings for slow clock controller
on at91sam9n12.dtsi (which includes #clock-cells and clocks bindings and
removes slck, slow_osc, slow_rc_osc)
- patch 4/5 in this series does s/sckc@/clock-controller@/ in all AT91
device trees.
Moreover, I've re-checked all the individual dtsi files that describes a
slow clock controller and all descriptions has the "#clock-cells", "clocks"
property available and no slck, slow_osc, slow_rc_osc as childs of
sckc@fffffe50.
If not, could you please let me know your checker command?
Thank you,
Claudiu
next prev parent reply other threads:[~2023-05-18 8:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 9:41 [PATCH v5 0/5] dt-bindings: clocks: at91: convert to yaml Claudiu Beznea
2023-05-17 9:41 ` [PATCH v5 1/5] ARM: dts: at91: use clock-controller name for PMC nodes Claudiu Beznea
2023-05-17 9:41 ` [PATCH v5 2/5] dt-bindings: clocks: atmel,at91rm9200-pmc: convert to yaml Claudiu Beznea
2023-05-17 12:42 ` Conor Dooley
2023-05-17 14:21 ` Krzysztof Kozlowski
2023-05-18 6:03 ` Claudiu.Beznea
2023-05-18 7:05 ` Krzysztof Kozlowski
2023-05-17 9:41 ` [PATCH v5 3/5] ARM: dts: at91: at91sam9n12: witch sckc to new clock bindings Claudiu Beznea
2023-05-17 9:41 ` [PATCH v5 4/5] ARM: dts: at91: use clock-controller name for sckc nodes Claudiu Beznea
2023-05-17 9:41 ` [PATCH v5 5/5] dt-bindings: clocks: at91sam9x5-sckc: convert to yaml Claudiu Beznea
2023-05-17 14:15 ` Krzysztof Kozlowski
2023-05-18 8:31 ` Claudiu.Beznea [this message]
2023-05-18 12:11 ` Krzysztof Kozlowski
2023-05-22 13:04 ` [PATCH v5 0/5] dt-bindings: clocks: at91: " Claudiu.Beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79b77cb4-1e18-3c19-15dd-66951541abdf@microchip.com \
--to=claudiu.beznea@microchip.com \
--cc=Conor.Dooley@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox