The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Shuah Khan <shuah@kernel.org>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: syzbot <syzbot+bccc1fe10b70fadc78d0@syzkaller.appspotmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	USB list <linux-usb@vger.kernel.org>,
	syzkaller-bugs <syzkaller-bugs@googlegroups.com>,
	Valentina Manea <valentina.manea.m@gmail.com>,
	Shuah Khan <shuah@kernel.org>
Subject: Re: KASAN: slab-out-of-bounds Read in vhci_hub_control
Date: Tue, 2 Oct 2018 17:21:04 -0600	[thread overview]
Message-ID: <79b7f7a1-1287-1341-7f30-c9491c4d0e4d@kernel.org> (raw)
In-Reply-To: <CACT4Y+bycsbrkeT8PHYxfooTkw2VyCAONY_BH2dTuZKtvCj3pg@mail.gmail.com>

On 10/02/2018 10:42 AM, Dmitry Vyukov wrote:
> On Tue, Oct 2, 2018 at 6:04 PM, Shuah Khan <shuah@kernel.org> wrote:
>> On 09/04/2018 12:52 PM, syzbot wrote:
>>> Hello,
>>>
>>> syzbot found the following crash on:
>>>
>>> HEAD commit:    420f51f4ab6b Merge tag 'arm64-fixes' of git://git.kernel.o..
>>> git tree:       upstream
>>> console output: https://syzkaller.appspot.com/x/log.txt?x=126a6f0e400000
>>> kernel config:  https://syzkaller.appspot.com/x/.config?x=531a917630d2a492
>>> dashboard link: https://syzkaller.appspot.com/bug?extid=bccc1fe10b70fadc78d0
>>> compiler:       gcc (GCC) 8.0.1 20180413 (experimental)
>>> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=121caa46400000
>>> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=14ed8ab6400000
>>
>> C producer doesn't reproduce the problem on 4.19-rc5. Does this C producer
>> depend on state of the machine? i.e what is the status of vhci_hcd - are
>> there any devices attached?
> 
> Hi Shuah,
> 
> syzbot always runs tests reproducers on a clean machine. There is some
> state are running a Debian wheezy init, but no test/fuzz/stress
> workload is run before the reproducer.
> syzbot also uses VMs, so there are no real devices attached. And it's
> GCE VMs (not qemu), and I think GCE does not even emulate any USB
> devices.
> 
> An obvious thing to try would be to use the exact commit and config
> syzbot gave (rather than 4.19-rc5).
> You can also take the image syzbot uses here:
> https://github.com/google/syzkaller/blob/master/docs/syzbot.md#crash-does-not-reproduce
> 
> 
>> I can see the problem looking at the code and fix is easy. However, I would
>> like be able to reproduce it and verify the fix works. Also this would be a
>> good regression for the driver I could consider adding to selftests.
> 
> syzbot can test fixes for bugs with reproducers:
> https://github.com/google/syzkaller/blob/master/docs/syzbot.md#testing-patches
> So it can test your fix. But this obviously won't help with a test.
> 

Tried the same config and no luck. Any chance you have the complete dmesg?

thanks,
-- Shuah

  reply	other threads:[~2018-10-02 23:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-04 18:52 KASAN: slab-out-of-bounds Read in vhci_hub_control syzbot
2018-10-02 16:04 ` Shuah Khan
2018-10-02 16:42   ` Dmitry Vyukov
2018-10-02 23:21     ` Shuah Khan [this message]
2018-10-10 18:41       ` Dmitry Vyukov
2018-10-10 18:43         ` Dmitry Vyukov
2018-10-10 19:42   ` Dmitry Vyukov
2018-10-10 20:26     ` Shuah Khan
2018-10-11  7:48       ` Dmitry Vyukov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=79b7f7a1-1287-1341-7f30-c9491c4d0e4d@kernel.org \
    --to=shuah@kernel.org \
    --cc=dvyukov@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=syzbot+bccc1fe10b70fadc78d0@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=valentina.manea.m@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox