From: Dave Hansen <dave.hansen@intel.com>
To: Chuyi Zhou <zhouchuyi@bytedance.com>,
tglx@kernel.org, mingo@redhat.com, luto@kernel.org,
peterz@infradead.org, paulmck@kernel.org, muchun.song@linux.dev,
bp@alien8.de, dave.hansen@linux.intel.com, pbonzini@redhat.com,
bigeasy@linutronix.de, clrkwllms@kernel.org, rostedt@goodmis.org,
nadav.amit@gmail.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 12/12] x86/mm: Enable preemption during flush_tlb_kernel_range
Date: Thu, 4 Jun 2026 14:21:44 -0700 [thread overview]
Message-ID: <79c1e9c7-574b-4065-ae70-9063fb554b5d@intel.com> (raw)
In-Reply-To: <20260528151338.617843-13-zhouchuyi@bytedance.com>
On 5/28/26 08:13, Chuyi Zhou wrote:
> - info->initiating_cpu = smp_processor_id();
> + info->initiating_cpu = raw_smp_processor_id();
> info->trim_cpumask = 0;
> }
Doesn't this turn ->initiating_cpu into garbage? It doesn't mean
anything any more other than being a random record of the past.
I think it's just used for stats, so not the end of the world. But, the
warning is there for a *REASON*. Please don't just turn it off and
ignore the fallout.
I'm also just generally not sure this is worth it. Kernel TLB flushes
stink. This just makes them stink slightly less. Maybe imperceptibly so.
Is it worth the churn?
next prev parent reply other threads:[~2026-06-04 21:21 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-28 15:13 [PATCH v6 00/12] Allow preemption during IPI completion waiting to improve real-time performance Chuyi Zhou
2026-05-28 15:13 ` [PATCH v6 01/12] smp: Disable preemption explicitly in __csd_lock_wait Chuyi Zhou
2026-05-28 15:13 ` [PATCH v6 02/12] smp: Enable preemption early in smp_call_function_single Chuyi Zhou
2026-05-28 15:13 ` [PATCH v6 03/12] smp: Refactor remote CPU selection in smp_call_function_any() Chuyi Zhou
2026-05-28 15:13 ` [PATCH v6 04/12] smp: Use task-local IPI cpumask in smp_call_function_many_cond() Chuyi Zhou
2026-06-03 10:54 ` Sebastian Andrzej Siewior
2026-06-03 11:48 ` Chuyi Zhou
2026-06-03 12:21 ` Sebastian Andrzej Siewior
2026-05-28 15:13 ` [PATCH v6 05/12] smp: Alloc percpu csd data in smpcfd_prepare_cpu() only once Chuyi Zhou
2026-05-28 15:13 ` [PATCH v6 06/12] smp: Enable preemption early in smp_call_function_many_cond Chuyi Zhou
2026-06-03 11:00 ` Sebastian Andrzej Siewior
2026-06-03 11:54 ` Chuyi Zhou
2026-05-28 15:13 ` [PATCH v6 07/12] smp: Remove preempt_disable from smp_call_function Chuyi Zhou
2026-05-28 15:13 ` [PATCH v6 08/12] smp: Remove preempt_disable from on_each_cpu_cond_mask Chuyi Zhou
2026-05-28 15:13 ` [PATCH v6 09/12] scftorture: Remove preempt_disable in scftorture_invoke_one Chuyi Zhou
2026-05-28 15:13 ` [PATCH v6 10/12] x86/mm: Move flush_tlb_info back to the stack Chuyi Zhou
2026-06-04 20:54 ` Dave Hansen
2026-06-04 21:11 ` Nadav Amit
2026-06-04 21:16 ` Dave Hansen
2026-06-04 21:21 ` Nadav Amit
2026-06-05 2:54 ` Chuyi Zhou
2026-05-28 15:13 ` [PATCH v6 11/12] x86/mm: Enable preemption during native_flush_tlb_multi Chuyi Zhou
2026-06-04 21:15 ` Dave Hansen
2026-06-05 3:36 ` Chuyi Zhou
2026-05-28 15:13 ` [PATCH v6 12/12] x86/mm: Enable preemption during flush_tlb_kernel_range Chuyi Zhou
2026-06-04 21:21 ` Dave Hansen [this message]
2026-06-05 3:51 ` Chuyi Zhou
2026-05-28 19:47 ` [PATCH v6 00/12] Allow preemption during IPI completion waiting to improve real-time performance Paul E. McKenney
2026-05-29 3:22 ` Chuyi Zhou
2026-05-29 6:41 ` Sebastian Andrzej Siewior
2026-06-03 11:02 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79c1e9c7-574b-4065-ae70-9063fb554b5d@intel.com \
--to=dave.hansen@intel.com \
--cc=bigeasy@linutronix.de \
--cc=bp@alien8.de \
--cc=clrkwllms@kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=muchun.song@linux.dev \
--cc=nadav.amit@gmail.com \
--cc=paulmck@kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@kernel.org \
--cc=zhouchuyi@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox