From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752241AbdDII2e (ORCPT <rfc822;w@1wt.eu>);
        Sun, 9 Apr 2017 04:28:34 -0400
Received: from mout.web.de ([212.227.17.12]:50617 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751814AbdDII2W (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 9 Apr 2017 04:28:22 -0400
Subject: Re: [PATCH v3] ia64: fix module loading for gcc-5.4
To: Sergei Trofimovich <slyfox@gentoo.org>
Cc: linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Fenghua Yu <fenghua.yu@intel.com>, "H . J . Lu" <hjl.tools@gmail.com>,
        Tony Luck <tony.luck@intel.com>
References: <to=<20170408081449.4872-1-slyfox@gentoo.org>
 <20170408195318.18080-1-slyfox@gentoo.org>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <79cc2afd-1655-c276-a53f-2e2202a7e0ee@users.sourceforge.net>
Date: Sun, 9 Apr 2017 10:27:52 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.0
MIME-Version: 1.0
In-Reply-To: <20170408195318.18080-1-slyfox@gentoo.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:A82K8B9sBTQK/VWXIMl44EwmS7vlAOQjRbcnC9LnIQdIft+7Gvd
 XRr+CuVpjF75lcjevHwBSGqqC2AmuJQLu01Q3peaVo0RC6L8Stj3MNFUNX4zPWIhPQcFSPK
 LLIh5vyTbYySNgXPeMcAK4zUAr9r29BlT2H5kJOJJ95Dyk+leULR1x7wI7eTqIHu0IY4aGn
 u7QnugVONvT1cq5Hxsahg==
X-UI-Out-Filterresults: notjunk:1;V01:K0:EXVDq5ooIoE=:iqVSuVxupDbDWhHK0Y24Kx
 pXYi/vRNXHlpoFmY9c7YO7gNu8ewnRBwf4T3xropokVsibma2NnkgdqEmIPJXvKy5dbhLLx+M
 frSHE4GZAq7BS8Yrotiy8x90+DqVS5t3S9uFEX+JgDpsK4U9Wxn81mX66CkX5M7Hem3Z6ghYJ
 j4cAvNYI4PA+vz/6SM+us+ibveb1Kv3etpnvJXoyt2yqAYXQr5RoK7QIWLdqhnGxKZ6K59/ki
 +dQLuE5s7ofy4ap36I/7yiiVfNX3Fx74B/JEneKxfXEUjJ+YoGhIz3kbAtuQHm/z6K6vAoGo7
 w/cLaVo3NHmGaXRciADwuM2x2l/bouVCHors9BuD7f7MLzl+/T/iy3xITese3jSCO/9KXlV/Z
 BRgkf43Z2SIIozdcfGr7ugv8xC1jcstZhtidH7bzSEvqgLhzrdWlJtc6k3lpKEt27GBX9yQ6U
 hWXQbbMqVyfxyLahN70A8GZNgHrPjNCzQQ3vGgNgIqYQBf03sV4MI06v2aQ6Hy+WqT2cjsLYm
 +RnPbg/VOyePpoXbqb3u71J49n+7BsedndCH+YkmVodiOhKHAa7+g8vRWalSewiE2SwbcNmwp
 3pDcXXKaj75omK7LHnCQUFaPDWvGBXri7XCh0azjO4RTk2fdYewzCKPmw0OuCnLAsrAUjsZVV
 H2Yu2aGSYR8ccRsK9FrJylISuMtdeOTekirtg4N9eH7j42ucBW3IxXr5TbCYR7xX0sifSGrug
 STwbi/ubgyGOR6A/2TF+1PTDfyLy2uph3nmgn7qtXwelaElpUd8hySzERXH5MpTqiLnp1vNQ0
 5AGGmTT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Starting from gcc-5.4+ gcc generates MLX

How do you think about to omit the plus character?


> instructions in more cases to refer local
> symbols:

I wonder about your choice of a line length limit here.


> That caused ia64 module loader to choke
> on such instructions:
>     fuse: invalid slot number 1 for IMM64

Why does it matter to check such a value?


> … That limitation was fixed in linux by

Would it be nicer to write “in corresponding source code by the”?


> Change since v2: checkpatched, fixed typos by found by Markus Elfring

Does this version information contain an unwanted word repetition?
How does it fit to the identifier “v3” in the commit subject?

Regards,
Markus