From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C1CC15539A for ; Mon, 3 Nov 2025 14:00:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762178417; cv=none; b=H2MS5oIRPgi+UYmur0OvOBE7oBkkfSquFXWmdGbZnmq22ba8HycumRpMuz97GP/O0zpEygJPI8RNaZ+FjrJF09pNmgTOuAgaXgL1sV5k2j//j1s48DVbJcqzXaIUrM1ikM7unx6RqZf7CyJ/DXTyP7HLv6ssEfF94ecdNHOWml0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762178417; c=relaxed/simple; bh=08PC3/AvFg4BABny9/8my4vAacX9aJRn5UW8imC12P4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RAKt7+0NSuU2UGVxnyhxHBwDMXwLn68kjARmu9oUSlMl2q1lvjBDvMIYAkCUyT5YlMYHCENL7AEZNlzSO6YEmToyUKIMY9k5rKimPEtwq0ERITvjm4zD2gV4wUgdGcTNIehi9glvDxsy5zTpDGfjMw3ETRmuL1SxODoiHknQh2w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=sUw80VCp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sUw80VCp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4EF79C4CEE7; Mon, 3 Nov 2025 14:00:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1762178416; bh=08PC3/AvFg4BABny9/8my4vAacX9aJRn5UW8imC12P4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=sUw80VCpomPZrm81732UjVojj5Qvf3UxuVADgq1JY2zGk2KPxO4eQGAjSigELTMDi H1s7fZiywF7FXUP/yldLUH6X7YGVxy46h8HfBHiuCqG0dayMJ+XLLkW6MLgqsrSaNC 3AnGk1eX+Z0wdrYNTWJUBIAASenX3gNm/KyqiI49n8ayxRy1v0OFR7cnqKyp2+ILUV +RTd11iKudbDIzDZIMRUy57Z8Z+2lbSVw1om5A7ifi8HTP89ipZvJOFXSceNweH4NQ yxbTi5ErQnmxPsIDKjiFJVR2cpmlyfWNOYcBs+1WndiNmD6Q++pIy2JYEmFYSQkGct au4jlnQVSWbzg== Message-ID: <79d45a6d-df37-475a-9edd-57e7a06155e3@kernel.org> Date: Mon, 3 Nov 2025 15:00:11 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 09/13] platform/raspberrypi: Add new vc-sm-cma driver To: Jai Luthra , Florian Fainelli , Raspberry Pi Kernel Maintenance , Dave Stevenson , bcm-kernel-feedback-list@broadcom.com Cc: Phil Elwell , Stefan Wahren , Laurent Pinchart , Kieran Bingham , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dom Cobley , Alexander Winkowski , Greg Kroah-Hartman , Juerg Haefliger References: <20251031-b4-vc-sm-cma-v1-0-0dd5c0ec3f5c@ideasonboard.com> <20251031-b4-vc-sm-cma-v1-9-0dd5c0ec3f5c@ideasonboard.com> <176217777617.8690.2075618272816893198@freya> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <176217777617.8690.2075618272816893198@freya> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 03/11/2025 14:49, Jai Luthra wrote: > Hi Krzysztof, > > > Thanks for the review. > > Quoting Krzysztof Kozlowski (2025-11-02 15:00:58) >> On 31/10/2025 18:27, Jai Luthra wrote: >>> From: Dave Stevenson >>> >>> Add Broadcom VideoCore Shared Memory support. >> >> You will have to come with really, really good argument why CMA is not >> working for you. This is how you write commit msgs. All further is not >> really helpful. >> > > From my limited understanding, this driver allows sharing buffers between > the kernel and the firmware that controls the ISP and codec on the remote > VideoCore VPU. > > Maybe Dave can comment better on the historical reasons of this approach > versus other DMA buffer sharing mechanisms available in the kernel, and if > it is feasible/possible to make that change today. You are upstreaming this so you have to come with rationale and detailed analysis why existing infrastructure cannot work here. Of course maybe it's just commit description which needs improvement. But anyway, please do not send downstream Rpi drivers to us just because downstream has them. That's never a good enough reason. And that is the only impression you are making here. ... >>> + >>> +module_vchiq_driver(bcm2835_vcsm_cma_driver); >>> + >>> +MODULE_AUTHOR("Dave Stevenson"); >>> +MODULE_DESCRIPTION("VideoCore CMA Shared Memory Driver"); >>> +MODULE_LICENSE("GPL"); >>> +MODULE_ALIAS("vcsm-cma"); >> >> Why don't you have proper ID table? How this driver is supposed to be >> instantiated? >> > > Sorry, I was unaware of this discussion: > https://lore.kernel.org/linux-media/2023100955-stunt-equate-c6fa@gregkh/ > > I will switch to using an ID table. > > This and other drivers for audio, isp, codec are all instantiated as > platform drivers under the VCHIQ bus (PATCH 13/13). If you have a bus, not some sort of MFD device, then you should use bus way of binding, which means in almost all cases providing an ID table, which will generate proper aliases. MODULE_ALIAS is basically only for the few cases where platform driver registers another platform device or for MFD (and even then only for few MFD cases). Best regards, Krzysztof