public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Huang, Honglei1" <Honglei1.Huang@amd.com>
To: Dmitry Osipenko <dmitry.osipenko@collabora.com>,
	Demi Marie Obenour <demiobenour@gmail.com>,
	David Airlie <airlied@redhat.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Gurchetan Singh <gurchetansingh@chromium.org>,
	Chia-I Wu <olvaffe@gmail.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Simona Vetter <simona@ffwll.ch>, Rob Clark <robdclark@gmail.com>,
	Huang Rui <ray.huang@amd.com>
Cc: dri-devel@lists.freedesktop.org, virtualization@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/7] virtio-gpu api: add blob userptr resource
Date: Thu, 27 Mar 2025 11:00:27 +0800	[thread overview]
Message-ID: <79d642cc-fe61-48c3-bda1-aafeeb07fe2a@amd.com> (raw)
In-Reply-To: <85470439-3c03-4787-be91-b6b680a5aca5@collabora.com>



On 2025/3/26 22:46, Dmitry Osipenko wrote:
> On 3/6/25 13:51, Huang, Honglei1 wrote:
>>
>> On 2025/3/1 5:21, Demi Marie Obenour wrote:
>>> On 2/28/25 12:36 AM, Honglei Huang wrote:
>>>> From: Honglei Huang <Honglei1.Huang@amd.com>
>>>>
>>>> Add a new resource for blob resource, called userptr, used for let
>>>> host access guest user space memory, to acquire buffer based userptr
>>>> feature in virtio GPU.
>>>>
>>>> - The capset VIRTIO_GPU_CAPSET_HSAKMT used for context init,
>>>> in this series patches only HSAKMT context can use the userptr
>>>> feature. HSAKMT is a GPU compute library in HSA stack, like
>>>> the role libdrm in mesa stack.
>>>
>>> Userptr should not be limited to HSMKMT contexts.  Userptr can
>>> accelerate shm buffers by avoiding a copy from guest to host, and
>>> it can be implemented using grant tables on Xen.
>>
>> Yes, I totally agree userptr can accelerate shm buffers, but I currently
>> don't know if there are any other projects working on similar features,
>> or if maintainers have any opinions or better ways to implement them, so
>> I temporarily limit this feature to HSAKMT context only.
>>
>> I am waiting for everyone's opinions, please provide your thoughts.
> 
> USERPTR should be relevant for anything Vulkan-related, like Venus and
> native contexts. I expect that this new feature will work universally
> good for all context types.
> 
> In order to merge USERPTR support upstream, we at least will need to
> prototype the guest USERPTR in one of native context driver to know that
> it works. You'll need to post the whole set of host/guest USERPTR
> patches including QEMU and etc, not just the kernel patches.

Ok totally understood, I will upload other components as soon as 
possiable, cause we only have limited resource for this matter, please 
understand the speed is relatively slow.
And for Vulkan use case, yes it is very important, I will make some 
prototype implementation for it, and will test it locally. The 
implementation for USERPTR must comply with Vulakan's standard.
Really thanks for your comments.

Reagrds,
Honglei

> 


  reply	other threads:[~2025-03-27  3:00 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-28  5:36 [PATCH v1 0/7] Add virtio gpu userptr support Honglei Huang
2025-02-28  5:36 ` [PATCH v1 1/7] virtio-gpu api: add blob userptr resource Honglei Huang
2025-02-28 21:21   ` Demi Marie Obenour
2025-03-06 10:51     ` Huang, Honglei1
     [not found]       ` <CAAfnVBk-JJKxJXAstwmgL4=EM15RHfVm4NQST+p3nE4xi2220g@mail.gmail.com>
2025-03-18 11:25         ` Huang, Honglei1
2025-03-24  2:44           ` Huang, Honglei1
2025-03-26 14:46       ` Dmitry Osipenko
2025-03-27  3:00         ` Huang, Honglei1 [this message]
2025-03-28  1:39           ` Dmitry Osipenko
2025-03-29 19:50         ` Demi Marie Obenour
2025-03-30 11:57           ` Dmitry Osipenko
2025-02-28  5:36 ` [PATCH v1 2/7] drm/virtgpu " Honglei Huang
2025-02-28  5:36 ` [PATCH v1 3/7] drm/virtio: implement userptr: probe for the feature Honglei Huang
2025-02-28  5:36 ` [PATCH v1 4/7] drm/virtio: implement userptr: add userptr obj Honglei Huang
2025-02-28  5:36 ` [PATCH v1 5/7] drm/virtio: advertise base userptr feature to userspace Honglei Huang
2025-02-28  5:36 ` [PATCH v1 6/7] drm/virtio: implement userptr: add interval tree Honglei Huang
2025-02-28  5:36 ` [PATCH v1 7/7] drm/virtio: implement userptr: add mmu notifier Honglei Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=79d642cc-fe61-48c3-bda1-aafeeb07fe2a@amd.com \
    --to=honglei1.huang@amd.com \
    --cc=airlied@redhat.com \
    --cc=demiobenour@gmail.com \
    --cc=dmitry.osipenko@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gurchetansingh@chromium.org \
    --cc=kraxel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=olvaffe@gmail.com \
    --cc=ray.huang@amd.com \
    --cc=robdclark@gmail.com \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    --cc=virtualization@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox