public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lukasz Luba <lukasz.luba@arm.com>
To: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	"open list:THERMAL" <linux-pm@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Quentin Perret <qperret@google.com>,
	Vincent Donnefort <vincent.donnefort@arm.com>,
	Beata Michalska <Beata.Michalska@arm.com>,
	Ingo Molnar <mingo@redhat.com>,
	Juri Lelli <juri.lelli@redhat.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	segall@google.com, Mel Gorman <mgorman@suse.de>,
	Daniel Bristot de Oliveira <bristot@redhat.com>,
	Thara Gopinath <thara.gopinath@linaro.org>,
	Amit Kachhap <amit.kachhap@gmail.com>,
	Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>
Subject: Re: [PATCH v4 2/3] sched/fair: Take thermal pressure into account while estimating energy
Date: Wed, 16 Jun 2021 21:22:40 +0100	[thread overview]
Message-ID: <79dbb2ad-88c1-ff08-59c8-7728d37ee78a@arm.com> (raw)
In-Reply-To: <CAKfTPtCpWrubqp2W8NQA0JTh2dJx3oxGuCBJbZ04reFzCbDxEg@mail.gmail.com>



On 6/16/21 8:25 PM, Vincent Guittot wrote:
> On Wed, 16 Jun 2021 at 19:24, Dietmar Eggemann <dietmar.eggemann@arm.com> wrote:
>>
>> On 15/06/2021 18:09, Lukasz Luba wrote:
>>>
>>> On 6/15/21 4:31 PM, Dietmar Eggemann wrote:
>>>> On 14/06/2021 21:11, Lukasz Luba wrote:
>>
>> [...]
>>
>>>> It's important to highlight that this will only fix this issue between
>>>> schedutil and EAS when it's due to `thermal pressure` (today only via
>>>> CPU cooling). There are other places which could restrict policy->max
>>>> via freq_qos_update_request() and EAS will be unaware of it.
>>>
>>> True, but for this I have some other plans.
>>
>> As long as people are aware of the fact that this was developed to be
>> beneficial for `EAS - IPA` integration, I'm fine with this.
> 
> I don't think it's only for EAS - IPA. Thermal_pressure can be used by
> HW throttling like here:
> https://lkml.org/lkml/2021/6/8/1791
> 
> EAS is involved but not IPA

Thank you Vincent for pointing to Thara's patches. Indeed, this is a
good example. We will have to provide similar for our SCMI perf
notifications - these are the plans that I've mentioned. In both
new examples, the IPA (or other governors) won't be even involved.

  reply	other threads:[~2021-06-16 20:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-14 18:58 [PATCH v4 0/3] Add allowed CPU capacity knowledge to EAS Lukasz Luba
2021-06-14 19:10 ` [PATCH 1/3] thermal: cpufreq_cooling: Update also offline CPUs per-cpu thermal_pressure Lukasz Luba
2021-06-18  8:46   ` [tip: sched/core] thermal/cpufreq_cooling: Update " tip-bot2 for Lukasz Luba
2021-06-14 19:11 ` [PATCH v4 2/3] sched/fair: Take thermal pressure into account while estimating energy Lukasz Luba
2021-06-15 15:31   ` Dietmar Eggemann
2021-06-15 16:09     ` Lukasz Luba
2021-06-16 17:24       ` Dietmar Eggemann
2021-06-16 18:31         ` Lukasz Luba
2021-06-16 19:25         ` Vincent Guittot
2021-06-16 20:22           ` Lukasz Luba [this message]
2021-06-18  8:46   ` [tip: sched/core] " tip-bot2 for Lukasz Luba
2021-06-14 19:12 ` [PATCH v4 3/3] sched/cpufreq: Consider reduced CPU capacity in energy calculation Lukasz Luba
2021-06-18  8:46   ` [tip: sched/core] " tip-bot2 for Lukasz Luba
2021-06-16 13:33 ` [PATCH v4 0/3] Add allowed CPU capacity knowledge to EAS Lukasz Luba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=79dbb2ad-88c1-ff08-59c8-7728d37ee78a@arm.com \
    --to=lukasz.luba@arm.com \
    --cc=Beata.Michalska@arm.com \
    --cc=amit.kachhap@gmail.com \
    --cc=amitk@kernel.org \
    --cc=bristot@redhat.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=dietmar.eggemann@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=qperret@google.com \
    --cc=rjw@rjwysocki.net \
    --cc=rostedt@goodmis.org \
    --cc=rui.zhang@intel.com \
    --cc=segall@google.com \
    --cc=thara.gopinath@linaro.org \
    --cc=vincent.donnefort@arm.com \
    --cc=vincent.guittot@linaro.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox