public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "sugaken.r3@gmail.com" <sugaken.r3@gmail.com>
To: wim@iguana.be
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] softdog - panic instead of reboot, kernel 2.6.22.9
Date: Wed, 10 Oct 2007 15:42:32 +0900	[thread overview]
Message-ID: <7DC80B08BC13EBsugaken.r3@gmail.com> (raw)

>From Ken Sugawara <sugaken.r3@gmail.com>

Description: Add an option to softdog to panic upon timer expiration 
instead of reboot.

Signed-off-by: Ken Sugawara <sugaken.r3@gmail.com>
---
This patch is intended to help increase the chance of postmortem 
analysis in the event of silent system hang where it is impossible to 
initiate crash dump manually (e.g. no console or network response).  
We've had occasions where some of our customers had silent system hang 
problems in which they were unable to obtain vmcore for root cause 
analysis.  Provided that timer interrupts are not blocked, this patch 
might enable them to get a crash dump in such a situation by activating 
softdog.

--- linux-2.6.22.9/drivers/char/watchdog/softdog.c.orig	2007-09-27 03:03:01.000000000 +0900
+++ linux-2.6.22.9/drivers/char/watchdog/softdog.c	2007-10-04 12:06:28.000000000 +0900
@@ -49,6 +49,7 @@
 #include <linux/jiffies.h>
 
 #include <asm/uaccess.h>
+#include <linux/kernel.h>
 
 #define PFX "SoftDog: "
 
@@ -70,6 +71,11 @@ static int soft_noboot = 0;
 module_param(soft_noboot, int, 0);
 MODULE_PARM_DESC(soft_noboot, "Softdog action, set to 1 to ignore reboots, 0 to reboot (default depends on ONLY_TESTING)");
 
+static int panic_instead = 0;
+
+module_param(panic_instead, int, 0);
+MODULE_PARM_DESC(panic_instead, "Softdog action, set to 1 to panic instead of reboot, 0 to reboot (default 0)");
+
 /*
  *	Our timer
  */
@@ -93,8 +99,11 @@ static void watchdog_fire(unsigned long 
 
 	if (soft_noboot)
 		printk(KERN_CRIT PFX "Triggered - Reboot ignored.\n");
-	else
-	{
+	else if (panic_instead) {
+		printk(KERN_CRIT PFX "Initiating panic.\n");
+		panic("Watchdog timer expired.");
+		printk(KERN_CRIT PFX "Panic didn't ?????\n");
+	} else {
 		printk(KERN_CRIT PFX "Initiating system reboot.\n");
 		emergency_restart();
 		printk(KERN_CRIT PFX "Reboot didn't ?????\n");
@@ -262,7 +271,7 @@ static struct notifier_block softdog_not
 	.notifier_call	= softdog_notify_sys,
 };
 
-static char banner[] __initdata = KERN_INFO "Software Watchdog Timer: 0.07 initialized. soft_noboot=%d soft_margin=%d sec (nowayout= %d)\n";
+static char banner[] __initdata = KERN_INFO "Software Watchdog Timer: 0.07 initialized. soft_noboot=%d soft_margin=%d sec panic_instead=%d (nowayout= %d)\n";
 
 static int __init watchdog_init(void)
 {
@@ -290,7 +299,7 @@ static int __init watchdog_init(void)
 		return ret;
 	}
 
-	printk(banner, soft_noboot, soft_margin, nowayout);
+	printk(banner, soft_noboot, soft_margin, panic_instead, nowayout);
 
 	return 0;
 }

             reply	other threads:[~2007-10-10  6:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-10  6:42 sugaken.r3 [this message]
2007-10-10 12:15 ` [PATCH] softdog - panic instead of reboot, kernel 2.6.22.9 Alan Cox
2007-10-11 10:25   ` Ken Sugawara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7DC80B08BC13EBsugaken.r3@gmail.com \
    --to=sugaken.r3@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox