From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4451D208D0 for ; Tue, 18 Nov 2025 00:41:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763426503; cv=none; b=oqm5nfHEDxNxkdsgX8zm7rDLxMF6/I/mupULT4v5e4mXl4iW97AawI1b6bPtbFu9lhuwBecgO0N9OJRL9SLlUv54N2EmYx873a1soCFPys/yYqHQQpJlC5hjvAooqEUH83/Y9cbs5Bf2/f+gjm9NDfk7oaKIJ7Ffb9HFiFvPsZI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763426503; c=relaxed/simple; bh=X/uY3KIjaOYxXSVQduhmDCM1gMqAsGS5H6FTfWw95Ek=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=KKJqcKXbkLHfTZAzEvQ8U+dnVKf/Ogcux4OaR6KAyy9pMb7giBXHpQRUbVzaJ9vyq4xEnSSoxQXsfRflApmhmOGTntlXyr8dhZe4JgcHk7wlxPkR8qRDdDx6c6U/XDQOuXnqEA6LRlvQZeJ4EBQ6BZuTyMILsFpZkRrQni50LjM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=i2DjbDqq; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="i2DjbDqq" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-343d73d08faso4452527a91.0 for ; Mon, 17 Nov 2025 16:41:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763426501; x=1764031301; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=bpHc2p8ODNNIK/lF6+XRFVKpyWeb8OJK3ymFZky/zH0=; b=i2DjbDqqYGNlUE0HXOk+vmIgmehMceCimvvDNVi0FTaqiimIGuWYNrIVqUgkgrfWPS FlgnVQ9iVAldgwJ/L/Olfyg4f+6GbbDapAudKlSskmG5VR/knogrhbLiZHEWTxqof2Lu o2eIf63NvY1eE015QHVazkD5BFn2/AQ5VX1kG74slR3N+6KIKiWTJ9ZUynaWB9Mr/4EP mdMBpo7vde2fNRYR6x+R7oUg2UC2F8WuCVyq0NRZd8zXKbUr6xJKE+Lg5FGSdPDjJ7bG BxpelS5TPmMMbS5yaiAka0l+IQdvx3Ca+0dYNJEoCBEiVnXKrMwfZu/f3kdgulH20U0B Te8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763426501; x=1764031301; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bpHc2p8ODNNIK/lF6+XRFVKpyWeb8OJK3ymFZky/zH0=; b=qE8JrkuYn5FYE5wDTIaIqEVI9lHimM9GtS4qxP1LBElhlJxQz3VSpVXexgkIsjpU2O D+MW+rwBC/V3lvmLYclcgO1Rpy5wQP0K8hqtGuaCs2UT5rvdYHi2pUVLB862nzm3VH4a 3kMSzatCzwci1huaKq5/CIiskBpyo5NY9tAxRp7jL0M2Hv/KPV966s0JJ6Oc7gVL3Nwy UCzOL7eWOGLEsRh7kFqZXSSj35G5VdIpE2yxnIA3hNqIB/wEVnmKKLoEUR6ssgaCPVEq L3mg2fl0oeNghmIjcX6ghOg9GMqicqCZx9oUuOnoGAjWcoqTCMjWOE4/ZoVRhxg3F3UN qmag== X-Gm-Message-State: AOJu0YxCLO8ZK+4wwNdr2Xn+vEqicS45P9QDyrnTIkPuBchorwYGffwn TN2sJ12YJtowVJTSOMNp07OPSKZ5u7v40h4hdsM6cYMGPoDmV+UxFX0A X-Gm-Gg: ASbGncvoDAZk4/oCblkhusKeKJJFbbVwdzXU+SW4zLElAmAHSU5fx/8fFUchT2FfS3N D4Ux5mbvs4Bx5KSGv+1j6KNOW3RCWFVsCBt4JZGKrDccmozMnO8yJDoeEyh1+JR0roX7/vn3d7H exXMkrBXfT+DFQFaetGyiUCEio+hmlE0IjW9pu+9Ow3OvL+irnULkTl58QfROuFWI5BZ3QBR/GI F0u9bRWexiP5YzXuXP3MyYoxTspBXh3DHkkHr4ABE6sECyXVCEGHUL8rsFXaXyn0IFCOjQXcD4o Ng1sLpCF7uxH8t8coLY/t1XZWJOz2C5cu3/feWaT3JklU1kSHfsFMLF7o/89w99fb9qG5TnBrn2 GPxq98BTckm8E7DjHaPdKwGhjatPRqq/7VakHwSz0MnNt9uajeVSrHbki4GhUqhAKxXsutNNc+p Xti514pm3aysWyA0Tk X-Google-Smtp-Source: AGHT+IEhFOKmc58ohvnpobB7KIG0elSsabMrwKXRwmi86n4DPe+i6UIYR5HA8VZ2wYsVPqZV67uguw== X-Received: by 2002:a17:90b:1b49:b0:343:a298:90ac with SMTP id 98e67ed59e1d1-345aea647d1mr1558664a91.0.1763426501585; Mon, 17 Nov 2025 16:41:41 -0800 (PST) Received: from [192.168.0.233] ([159.196.5.243]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-bc375081bf8sm13401253a12.24.2025.11.17.16.41.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Nov 2025 16:41:40 -0800 (PST) Message-ID: <7a0343ee69331f1ade97b909cfd13a1ff04a09ae.camel@gmail.com> Subject: Re: [PATCH v3 3/4] nvme: Expose the tls_configured sysfs for secure concat connections From: Wilfred Mallawa To: alistair23@gmail.com, kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me, hare@suse.de, kch@nvidia.com, linux-nvme@lists.infradead.org Cc: linux-kernel@vger.kernel.org, Alistair Francis Date: Tue, 18 Nov 2025 10:41:35 +1000 In-Reply-To: <20251114045850.1898865-4-alistair.francis@wdc.com> References: <20251114045850.1898865-1-alistair.francis@wdc.com> <20251114045850.1898865-4-alistair.francis@wdc.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.1 (3.58.1-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Fri, 2025-11-14 at 14:58 +1000, alistair23@gmail.com wrote: > From: Alistair Francis >=20 > Signed-off-by: Alistair Francis > Reviewed-by: Christoph Hellwig > --- > v3: > =C2=A0- No change > v2: > =C2=A0- New patch >=20 > =C2=A0drivers/nvme/host/sysfs.c | 2 +- > =C2=A01 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/nvme/host/sysfs.c b/drivers/nvme/host/sysfs.c > index 29430949ce2f..6d10e12136d0 100644 > --- a/drivers/nvme/host/sysfs.c > +++ b/drivers/nvme/host/sysfs.c > @@ -838,7 +838,7 @@ static umode_t nvme_tls_attrs_are_visible(struct > kobject *kobj, > =C2=A0 =C2=A0=C2=A0=C2=A0 !ctrl->opts->tls && !ctrl->opts->concat) > =C2=A0 return 0; > =C2=A0 if (a =3D=3D &dev_attr_tls_configured_key.attr && > - =C2=A0=C2=A0=C2=A0 (!ctrl->opts->tls_key || ctrl->opts->concat)) > + =C2=A0=C2=A0=C2=A0 !ctrl->opts->concat) > =C2=A0 return 0; > =C2=A0 if (a =3D=3D &dev_attr_tls_keyring.attr && > =C2=A0 =C2=A0=C2=A0=C2=A0 !ctrl->opts->keyring) Reviewed-by: Wilfred Mallawa Wilfred