From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757327AbdLWVjQ (ORCPT ); Sat, 23 Dec 2017 16:39:16 -0500 Received: from mout.web.de ([217.72.192.78]:54167 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752339AbdLWVjN (ORCPT ); Sat, 23 Dec 2017 16:39:13 -0500 Subject: [PATCH 1/3] pinctrl: rockchip: Delete error messages for a failed memory allocation in two functions From: SF Markus Elfring To: linux-gpio@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, =?UTF-8?Q?Heiko_St=c3=bcbner?= , Linus Walleij Cc: LKML , kernel-janitors@vger.kernel.org References: <323697d0-e1e8-8d3b-1070-f481cfa30b9a@users.sourceforge.net> Message-ID: <7a067193-e0c3-c2b9-b85a-e05c8ff8860e@users.sourceforge.net> Date: Sat, 23 Dec 2017 22:38:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <323697d0-e1e8-8d3b-1070-f481cfa30b9a@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:ir1pwvGXzbitwsvYO0YFQd1j8lg3ip5iDqQk12kEmnSXMBdk5+e 4wCG84NLOZMUHQbj6YIUdQ3h6MvTHAfPAkieGfyTBBf30Er/leKmMaQIgCmyTYdghNLBWjk XpYnXmP6hQ1z/7zE814HRve/dDzlWGLITxsyLGl4WI4dlNiZtSBDNhZAPDwEzsO/vqIXqJs vc4XCNL6D6NayLxtqJhmQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:TlKW4uZVJKY=:McRRyf0htwY0iJMQEZbpIc QMYFVlKQic5jP+wDlN6mL04v1rzu5wSAY4XwpCxBn3gG72I0rHrrS5s3OawH5y8ZcYjb4WCc/ VJmD3jNRmPaq8Bm7umVZDRN5/Qr4oGcTS9/W8FSAL6RNyv3ZEahaM4nGzz0ciEboNCXzNrJSH hxOWSwDpAAqx0s222eKqT8EH4O8X0ncR8amozTO+dSME88ZWCnk1fX1CN5FZ1Lwamour+3e7S uq+KfA1XicU2M0AUYxUVjEUAOEUy/AAqW3ie9BrLYezw1EtbJt1FS2wB5yJd93WaTeVZeBIjy J9WwGq6f3M0GayjvQq19nnt8PXXubBkqpDqNOLTYKFcXRBx1X5JomOB1h4j6F6ZXiuIvRjmVC dLyEtFiQUTC2lNdrsAywLY0/x4FXz0/RP4dzKcTTBbcHcrBwDUgFPdHOQwExnpWAYEzBxr6Is nUCUcTH3Dtrj1bdJILxMj3VXkshe5jeP3bpG8m1gXFoDXRRhfDOq1z/b3zu8OBnhnLVXGErxh BUbq4d7yxtzxhItzK7fC+Si7fim1YvJyrtGHjJk7i6q+kfO5qfZw/aO5sh/+YNvEFxF9k7uoi wVjlX4QdrruxZUg03xvARmi0hZE6lw95avJfB0eUMfKTzyVpxGDVZF7fJaVrXBjkjM/eCjYUi V+s4ElL5RS0fgCbyP2Zd0hVdtfyjLAzz5qivVqPB6Ici30npzn0vp90TM3/t0Ag2AJUlw7sH5 RXWOWrXUWo6jTr4j77kT7cE1wfJBuQMWY0JOkMd0V/+UwUAvM9/zNNF6wNDayyIsUek+x0IgQ /AlLA9Vs6Oab5adL4WQ0tcRN8P3SrtJlnlfcPbfu8Fp3LxUJ58= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 23 Dec 2017 22:02:47 +0100 Omit extra messages for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/pinctrl/pinctrl-rockchip.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c index 2ba17548ad5b..285169170eb2 100644 --- a/drivers/pinctrl/pinctrl-rockchip.c +++ b/drivers/pinctrl/pinctrl-rockchip.c @@ -2400,18 +2400,14 @@ static int rockchip_pinctrl_parse_dt(struct platform_device *pdev, info->functions = devm_kzalloc(dev, info->nfunctions * sizeof(struct rockchip_pmx_func), GFP_KERNEL); - if (!info->functions) { - dev_err(dev, "failed to allocate memory for function list\n"); + if (!info->functions) return -EINVAL; - } info->groups = devm_kzalloc(dev, info->ngroups * sizeof(struct rockchip_pin_group), GFP_KERNEL); - if (!info->groups) { - dev_err(dev, "failed allocate memory for ping group list\n"); + if (!info->groups) return -EINVAL; - } i = 0; @@ -2447,10 +2443,9 @@ static int rockchip_pinctrl_register(struct platform_device *pdev, pindesc = devm_kzalloc(&pdev->dev, sizeof(*pindesc) * info->ctrl->nr_pins, GFP_KERNEL); - if (!pindesc) { - dev_err(&pdev->dev, "mem alloc for pin descriptors failed\n"); + if (!pindesc) return -ENOMEM; - } + ctrldesc->pins = pindesc; ctrldesc->npins = info->ctrl->nr_pins; -- 2.15.1