From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751339AbdJRTXo (ORCPT ); Wed, 18 Oct 2017 15:23:44 -0400 Received: from mout.web.de ([217.72.192.78]:50895 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750914AbdJRTXm (ORCPT ); Wed, 18 Oct 2017 15:23:42 -0400 Subject: [PATCH 2/5] powerpc-pseries: Improve nine size determinations From: SF Markus Elfring To: linuxppc-dev@lists.ozlabs.org, Alex Williamson , Alexey Kardashevskiy , Andrew Morton , Bart Van Assche , Benjamin Herrenschmidt , David Gibson , Doug Ledford , Greg Kroah-Hartman , Johan Hovold , Masahiro Yamada , Michael Ellerman , Nathan Fontenot , Paul Mackerras , Rob Herring , Sahil Mehta , Tyrel Datwyler Cc: LKML , kernel-janitors@vger.kernel.org References: <0d221be4-1402-0499-d95e-afa4a30e1f33@users.sourceforge.net> Message-ID: <7a16a571-2087-7926-3ff7-e6252cf34734@users.sourceforge.net> Date: Wed, 18 Oct 2017 21:23:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <0d221be4-1402-0499-d95e-afa4a30e1f33@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:43YSptpV4p59b8HwKVabIP7p1tMisY+EQ3DWehlg2PZ9hMzgFnE LZinZWPjM+rhv9a2IOgJYZGz6/r0y21tg7b2E0pq9ckPNSBh1IDHhecZlLBDT7Y0ZR7wLsS 2j73rKqiRQZHy2kTtwDJ1PkMWVq6/93eP/NkBTE75IJaaUSTG/6tcMUGhFVOCMxvoFV8v8B OJu+AL0JY0lCqYRLO0a0g== X-UI-Out-Filterresults: notjunk:1;V01:K0:Pjgr1Q20vG8=:pG8tprZZtDjhhQjcsOMQTl lGyg/v7sdHG7Czv5YEf4lBvcEg8Rze5NA2nJgFHZ4DljIrjUAejUquyH29cQUGo1uPjxRPN7C 4hHMMuhnnA320mLV+zl+VW3OCn16Qk4e44CVMEJT/RT9/kZmMeLqD7MVdLQ/n70EMX0QDqGXv dvl1+7EP/Ty1OOT/Vg+cTb2SvGWjDIImvSoPH0O9MdhGveaE/dRvo1itAiZktu+aMfFZ+sv8/ 6WcI5tR5fTY0wWvOq7LRycdYN2nqvKEBXlmsPzTdeRuDsLDJ9AM1iebtu/7HxdzyE052SrWIr seupcB6JeF9NMjweiK4J71uSk3nk5QCLhvJv0dRx6YzlG+SEBSRGVwC+DZVCnp7r5e6tcePcx MyVF4I2Sv31UtLENN2pwFA1W2wUQu88euABhU6Rb1rTGlnQ9MrzbWj0qla5A5KTSYE70v2G6H YzRFraBM66vLBdhxw9SQWvtiBsTiKQ2USA9IX5o0LAlEK4508a4k4y2gZ++OuJRg8McWu20Ew zM+o304annOqMuHZd+TSi/jEwcmLR0S1Px0kG6+WDV1XC1Ph53D2nmKWtlzqhdjVECyUXrTk+ QoQ/A/988ZYVc85jbxftYxSSA/+0jQ693ecBwLUq7ZhmpvOWYiUhyolBiQosyzOrZ5aQZVO4+ wDdXbfVTChbM5HL54FfywwOhmcF4fSSwvv7z96MONztCPsNQ8DHI/P+zzUrJKTTXrPzKtKsnV 9VW8pY5kCNbANJl8sdgURFqOKcSHqsJuFUhReiupqUhGolomU/WRfUn/5SeJH2r+5FbThB59m Y/nM7YSVhXmn3Mv/Ktb2wkMpaY+HnrIVH2Oc+zQ7jDu3nrMIuc= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 18 Oct 2017 18:18:11 +0200 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- arch/powerpc/platforms/pseries/dlpar.c | 5 ++--- arch/powerpc/platforms/pseries/hvcserver.c | 5 ++--- arch/powerpc/platforms/pseries/iommu.c | 10 ++++------ arch/powerpc/platforms/pseries/vio.c | 5 ++--- 4 files changed, 10 insertions(+), 15 deletions(-) diff --git a/arch/powerpc/platforms/pseries/dlpar.c b/arch/powerpc/platforms/pseries/dlpar.c index 6e35780c5962..dca88997cb4b 100644 --- a/arch/powerpc/platforms/pseries/dlpar.c +++ b/arch/powerpc/platforms/pseries/dlpar.c @@ -389,11 +389,10 @@ void queue_hotplug_event(struct pseries_hp_errorlog *hp_errlog, struct pseries_hp_work *work; struct pseries_hp_errorlog *hp_errlog_copy; - hp_errlog_copy = kmalloc(sizeof(struct pseries_hp_errorlog), - GFP_KERNEL); + hp_errlog_copy = kmalloc(sizeof(*hp_errlog_copy), GFP_KERNEL); memcpy(hp_errlog_copy, hp_errlog, sizeof(struct pseries_hp_errorlog)); - work = kmalloc(sizeof(struct pseries_hp_work), GFP_KERNEL); + work = kmalloc(sizeof(*work), GFP_KERNEL); if (work) { INIT_WORK((struct work_struct *)work, pseries_hp_work_fn); work->errlog = hp_errlog_copy; diff --git a/arch/powerpc/platforms/pseries/hvcserver.c b/arch/powerpc/platforms/pseries/hvcserver.c index db2c20e65a58..b85cca04dd7d 100644 --- a/arch/powerpc/platforms/pseries/hvcserver.c +++ b/arch/powerpc/platforms/pseries/hvcserver.c @@ -173,9 +173,8 @@ int hvcs_get_partner_info(uint32_t unit_address, struct list_head *head, /* This is a very small struct and will be freed soon in * hvcs_free_partner_info(). */ - next_partner_info = kmalloc(sizeof(struct hvcs_partner_info), - GFP_ATOMIC); - + next_partner_info = kmalloc(sizeof(*next_partner_info), + GFP_ATOMIC); if (!next_partner_info) { hvcs_free_partner_info(head); return -ENOMEM; diff --git a/arch/powerpc/platforms/pseries/iommu.c b/arch/powerpc/platforms/pseries/iommu.c index c92822fdf269..b37d4fb20d1c 100644 --- a/arch/powerpc/platforms/pseries/iommu.c +++ b/arch/powerpc/platforms/pseries/iommu.c @@ -59,17 +59,15 @@ static struct iommu_table_group *iommu_pseries_alloc_group(int node) struct iommu_table *tbl = NULL; struct iommu_table_group_link *tgl = NULL; - table_group = kzalloc_node(sizeof(struct iommu_table_group), GFP_KERNEL, - node); + table_group = kzalloc_node(sizeof(*table_group), GFP_KERNEL, node); if (!table_group) goto fail_exit; - tbl = kzalloc_node(sizeof(struct iommu_table), GFP_KERNEL, node); + tbl = kzalloc_node(sizeof(*tbl), GFP_KERNEL, node); if (!tbl) goto fail_exit; - tgl = kzalloc_node(sizeof(struct iommu_table_group_link), GFP_KERNEL, - node); + tgl = kzalloc_node(sizeof(*tgl), GFP_KERNEL, node); if (!tgl) goto fail_exit; @@ -1062,7 +1060,7 @@ static u64 enable_ddw(struct pci_dev *dev, struct device_node *pdn) goto out_failed; } len = order_base_2(max_addr); - win64 = kzalloc(sizeof(struct property), GFP_KERNEL); + win64 = kzalloc(sizeof(*win64), GFP_KERNEL); if (!win64) goto out_failed; diff --git a/arch/powerpc/platforms/pseries/vio.c b/arch/powerpc/platforms/pseries/vio.c index 74b919040e68..cf0939eb3aee 100644 --- a/arch/powerpc/platforms/pseries/vio.c +++ b/arch/powerpc/platforms/pseries/vio.c @@ -754,8 +754,7 @@ static int vio_cmo_bus_probe(struct vio_dev *viodev) viodev->cmo.desired = VIO_CMO_MIN_ENT; size = VIO_CMO_MIN_ENT; - dev_ent = kmalloc(sizeof(struct vio_cmo_dev_entry), - GFP_KERNEL); + dev_ent = kmalloc(sizeof(*dev_ent), GFP_KERNEL); if (!dev_ent) return -ENOMEM; @@ -1385,7 +1384,7 @@ struct vio_dev *vio_register_device_node(struct device_node *of_node) } /* allocate a vio_dev for this node */ - viodev = kzalloc(sizeof(struct vio_dev), GFP_KERNEL); + viodev = kzalloc(sizeof(*viodev), GFP_KERNEL); if (!viodev) return NULL; -- 2.14.2