From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50D6D9443 for ; Wed, 29 Apr 2026 06:26:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777443962; cv=none; b=IsTGaby2VA4ewli2CLNFKv6uXtdE8xxLrnk4lbhm3E2L3Ys6yMcDsDlADm80EDPkRBYpi4XAYVDGnx8GiZa0qZZwx9+Y+BVCA6f0OLmJLua25Dc0mkhNugqad5IssNGl9sJQKQUABFnGZC6lL1hwu35lxhgqxRAi6oFmk7D50qs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777443962; c=relaxed/simple; bh=ZLqCgcENzbDmuWw3/IYd35vvgMiuLJTU1MiipLmd20k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Q31UYysdcuRwIDGJ2Bc9tCh4MJ6N9or0Yz9YKj1O2VXdAui2YwNLBaP5eENuIdQ4hb+PeBGLZztm3y/YzJFhFSqAh+oAbGHLBRl0tqyKl995cl5oKRGepWDtHdn7ceXuwgc3+rb1jgidm3vRrJtLj3wgDWmBaDpqnZhPWD2L90Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rD/wOIKV; arc=none smtp.client-ip=209.85.167.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rD/wOIKV" Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-5a74962749aso785618e87.3 for ; Tue, 28 Apr 2026 23:26:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777443959; x=1778048759; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=b2ra/cL6pAIpg0TWrgfpVFTftHGeLUpW/FdHh0Y70lk=; b=rD/wOIKV07LEVAVveADTEzjWT6v0U+cx/LMNkGGs/ja/pzLLc11fFDoQH27jTu8B7U pYBXEovjeTsq/St1r3vFQTDmbbQvx1AZFZGcPpv2NcY0xKy8NtwgghYAKkGxhI+bBgMG XWsZsv07pOskUzy5hO51VgDAIRwxSi4gFnTuXmSFrMyd76GtuJ7KKJP3rpYR9UTc+SU+ 0ATS0XEjBAwQN4U8YkLn8mfEBVot3bQYEF82wxfYaCMLWU+dUkCNHGl6XKDBbomfy6o8 elCBrmATGoIIgxGt78cUiVz8JghI+bIGge0PYFrZOo6JAHONNSLkCw7PSVeuvMauMu5A 5Drw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777443959; x=1778048759; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=b2ra/cL6pAIpg0TWrgfpVFTftHGeLUpW/FdHh0Y70lk=; b=kNG58KAc3UMh03GJzWiknGyULFmrRqb39XDOMDZB6SOFmSSS/6y47Np0AInZPm4FZT 5//KbDWyQBXAuyBgMGKzeMxDD5K0XSWFQAokOYUBCC7skllqUpn0IdPGI5llY3txmhHw kbyhXY7shGao9bUmTdSdQE5ONyLUuG0gxMaIe7mJs1YbyczlB20cNFIlUgEtfkUqTx9T IuTjFVqMoa+d+uixsyI5sqmAwPVBUvdjR2vkEm1tIb9IofGsa2Hed+1wZ/wwMtzgDreP tC6sO9q9P5XlcaURCObznsDYs6NCYJ+JDMIQMjHczagAIq0+gHHhUlSwSSjXQUAUpYcC PFRQ== X-Forwarded-Encrypted: i=1; AFNElJ93wQQ21x72gdxukBYIyvn1PqAJNajymKQaU9oIkCIEFRyZV3AzQjx7m/OsajSmY3Mx2ZFekSPqH5pHkx0=@vger.kernel.org X-Gm-Message-State: AOJu0YzDNfGVtTw/MDwcjzaUymOLoJrXvpMO1+tDDVNNOWqNmXApjPEy J6wnFUYRYntiXgu/PJPtTmM6x+3+HKeMRo0CDbmviZdCy+C2jeUzbZ0x X-Gm-Gg: AeBDies30tGv/I459e0nFfugMN/qNLE3MoVKrKxjnEYrBC7WroMR+yt0JYL7JYvNepz ZG3v+2OZQ0cp2Z0vECbApVoQ0To9ajLDJod6hexj3KpaYEAHqY8RFw1+/FaYfjV9TrZ4M0Sa2Tk t2FzhQRjtW9+jqdSkrussrYhrIoHRZxKwhLB9lBBIk1LA6lQsye9IMOebflwBngmWzj2SvVAz67 pBTvT3JvWurm0Fwx137Xie+EVjIUts0fbcoIAdJFOINhMnrYp1+wlZTwLJGcP5pKmdo21JDxiUz FLXxAXEz+66lAU1rd779VPlGEED/3RP3U9cxZAVx+Qdbr1x+iy9HVlSpKfnESU509yIUDmt+eTf WsM/geRPnDa+WFI4b4AJTcAzMyg06qPenCFWLlt6MCLKMBM+D6SNy2DD0LBMJJDclV+lA3AqWPZ UIwGjItdKt1N3z6M29NJmuLjjGOWqmIc6O3QECvu+sykUHi8XmMf+NlBf6iqm+cNTSxWw88UWgV Ap1dlfxN57yqZJKH8Q= X-Received: by 2002:a05:6512:3181:b0:5a3:ffdc:1d22 with SMTP id 2adb3069b0e04-5a74662a7e8mr2683695e87.36.1777443959279; Tue, 28 Apr 2026 23:25:59 -0700 (PDT) Received: from ?IPV6:2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703? ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a74a773599sm278769e87.77.2026.04.28.23.25.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Apr 2026 23:25:58 -0700 (PDT) Message-ID: <7a1bb930-da45-41af-bd27-9a10bd0c8be8@gmail.com> Date: Wed, 29 Apr 2026 09:25:57 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [v2] input: gpio-keys: make legacy gpiolib optional To: Dmitry Torokhov , Arnd Bergmann Cc: Lee Jones , Arnd Bergmann , Gatien Chevallier , Marco Crivellari , Fabrice Gasnier , Andreas Kemnade , Krzysztof Kozlowski , Charles Keepax , Christophe JAILLET , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260427143406.3020992-1-arnd@kernel.org> Content-Language: en-US, en-AU, en-GB, en-BW From: Matti Vaittinen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi deee Ho, On 28/04/2026 07:14, Dmitry Torokhov wrote: > On Mon, Apr 27, 2026 at 04:33:49PM +0200, Arnd Bergmann wrote: >> From: Arnd Bergmann >> >> Most users of gpio-keys and gpio-keys-polled use modern gpiolib >> interfaces, but there are still number of ancient sh, arm32 and x86 >> machines that have never been converted. >> >> Add an #ifdef block for the parts of the driver that are only used on >> those legacy machines. >> >> The two Rohm PMIC drivers use a gpio-keys device without an actual GPIO, >> passing an IRQ number instead. In order to keep this working both with >> and with CONFIG_GPIOLIB_LEGACY, change the gpio-keys driver to ignore >> the gpio number if an IRQ is passed. >> >> Link: https://lore.kernel.org/all/b3c94552-c104-42e3-be15-7e8362e8039e@gmail.com/ >> Signed-off-by: Arnd Bergmann >> --- >> v2: skip the fake GPIO number passing from mfd >> --- >> drivers/input/keyboard/gpio_keys.c | 7 ++++--- >> drivers/input/keyboard/gpio_keys_polled.c | 2 ++ >> drivers/mfd/rohm-bd71828.c | 1 - >> drivers/mfd/rohm-bd718x7.c | 1 - > > Let's see if my patches to rohm drivers will get accepted and then maybe > we can remove legacy gpio API from gpio-keys altogether. What comes to the ROHM drivers, I am ok with the "swnode stuff" proposed by Dmitry (if it helps with cropping some legacy). Still, from the ROHM driver POV, I sure have no problems with just simple zeroing the gpios and providing the IRQ which in driver side is clean(ish) and simpl(ish) :) So, in case someone opposes Dmitry's changes, for ROHM drivers: Acked-by: Matti Vaittinen -- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~