From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Pali Rohár" <pali@kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
Gregory Clement <gregory.clement@bootlin.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: marvell: Fix compatible strings for Armada 3720 boards
Date: Thu, 14 Jul 2022 08:56:12 +0200 [thread overview]
Message-ID: <7a4fba17-9c71-a4e6-643a-62aa0dfd4774@linaro.org> (raw)
In-Reply-To: <20220713200336.addvyfjhakrx72am@pali>
On 13/07/2022 22:03, Pali Rohár wrote:
> On Wednesday 13 July 2022 21:42:43 Krzysztof Kozlowski wrote:
>> On 13/07/2022 14:56, Pali Rohár wrote:
>>> All Armada 3720 boards have Armada 3720 processor which is of Armada 3700
>>> family and do not have Armada 3710 processor. So none of them should have
>>> compatible string for Armada 3710 processor.
>>>
>>> Fix compatible string for all these boards by removing wrong processor
>>> string "marvell,armada3710" and adding family string "marvell,armada3700"
>>> as the last one. (Note that this is same way how are defined Armada 3710
>>> DTS files).
>>
>> Please do not introduce some changes just in DTS, but start from the
>> bindings. Someone wrote the bindings like that and expected to be that
>> way, so first change the bindings with proper rationale. Then change the
>> DTS files.
>>
>>
>> Best regards,
>> Krzysztof
>
> Ok, I tried to update bindings and fix example in it, see patch:
> https://lore.kernel.org/linux-devicetree/20220713200123.22612-1-pali@kernel.org/
The reason you used here should be expressed in that commit as well
because you change the ABI and affect other users (projects, systems).
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-07-14 6:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 12:56 [PATCH] arm64: dts: marvell: Fix compatible strings for Armada 3720 boards Pali Rohár
2022-07-13 19:42 ` Krzysztof Kozlowski
2022-07-13 20:03 ` Pali Rohár
2022-07-14 6:56 ` Krzysztof Kozlowski [this message]
2022-07-14 9:36 ` Pali Rohár
2022-08-08 20:24 ` Pali Rohár
2022-08-08 20:33 ` Andrew Lunn
2022-08-08 20:39 ` Pali Rohár
2022-09-02 22:31 ` Pali Rohár
2022-09-19 23:19 ` Pali Rohár
2022-09-30 23:38 ` Pali Rohár
2022-10-09 12:06 ` Pali Rohár
2022-11-01 22:44 ` Pali Rohár
2022-11-28 18:21 ` Pali Rohár
2022-12-16 18:21 ` Pali Rohár
2023-01-22 11:28 ` Pali Rohár
2023-02-01 7:46 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a4fba17-9c71-a4e6-643a-62aa0dfd4774@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pali@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox