From: Florian Fainelli <f.fainelli@gmail.com>
To: David Miller <davem@davemloft.net>, Jisheng.Zhang@synaptics.com
Cc: andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/2] net: phy: call phy_disable_interrupts() in phy_init_hw()
Date: Wed, 24 Jun 2020 15:10:51 -0700 [thread overview]
Message-ID: <7a71ba71-b6cf-653d-967d-b74f930a69c5@gmail.com> (raw)
In-Reply-To: <20200624.144309.110827193136110443.davem@davemloft.net>
On 6/24/20 2:43 PM, David Miller wrote:
> From: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
> Date: Wed, 24 Jun 2020 11:25:16 +0800
>
>> We face an issue with rtl8211f, a pin is shared between INTB and PMEB,
>> and the PHY Register Accessible Interrupt is enabled by default, so
>> the INTB/PMEB pin is always active in polling mode case.
>>
>> As Heiner pointed out "I was thinking about calling
>> phy_disable_interrupts() in phy_init_hw(), to have a defined init
>> state as we don't know in which state the PHY is if the PHY driver is
>> loaded. We shouldn't assume that it's the chip power-on defaults, BIOS
>> or boot loader could have changed this. Or in case of dual-boot
>> systems the other OS could leave the PHY in whatever state."
>>
>> patch1 makes phy_disable_interrupts() non-static so that it could be used
>> in phy_init_hw() to have a defined init state.
>>
>> patch2 calls phy_disable_interrupts() in phy_init_hw() to have a
>> defined init state.
>>
>> Since v2:
>> - Don't export phy_disable_interrupts() but just make it non-static
>>
>> Since v1:
>> - EXPORT the correct symbol
>
> Series applied, thank you.
Did you mean that you applied v4? It does not look like you pushed your
local changes to net-next yet, so I cannot tell for sure.
--
Florian
next prev parent reply other threads:[~2020-06-24 22:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 3:25 [PATCH v3 0/2] net: phy: call phy_disable_interrupts() in phy_init_hw() Jisheng Zhang
2020-06-24 3:25 ` [PATCH v3 1/2] net: phy: make phy_disable_interrupts() non-static Jisheng Zhang
2020-06-24 3:26 ` [PATCH v3 2/2] net: phy: call phy_disable_interrupts() in phy_init_hw() Jisheng Zhang
2020-06-24 3:36 ` Florian Fainelli
2020-06-24 9:39 ` Russell King - ARM Linux admin
2020-06-24 21:43 ` [PATCH v3 0/2] " David Miller
2020-06-24 22:10 ` Florian Fainelli [this message]
2020-06-24 23:34 ` David Miller
2020-06-25 3:07 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7a71ba71-b6cf-653d-967d-b74f930a69c5@gmail.com \
--to=f.fainelli@gmail.com \
--cc=Jisheng.Zhang@synaptics.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox