From: Dave Hansen <dave.hansen@intel.com>
To: Uros Bizjak <ubizjak@gmail.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>
Subject: Re: [PATCH] x86/smp: Use atomic_try_cmpxchg() to micro-optimize native_stop_other_cpus()
Date: Wed, 22 Nov 2023 13:32:44 -0800 [thread overview]
Message-ID: <7aaa343e-365a-4c87-a139-7d26bbb50bd7@intel.com> (raw)
In-Reply-To: <CAFULd4bZPgY5Tw++UikUUF2fjL8teXRC3vfq=7hLeaDRDMgKBA@mail.gmail.com>
On 11/22/23 12:18, Uros Bizjak wrote:
> I'm not here to discuss policies, but the "don't fix it if it ain't
> broke" policy is a slippery slope, as it can lead to stagnation in the
> long term. Please read what happened here [1].
>
> [1] https://lwn.net/Articles/488847/
Even though I'm not dying to apply this patch, I will take a look at it
again if it improves in how its changelog is phrased, actually makes the
code more readable and comes with some kind of statement about how
thoroughly it was tested.
prev parent reply other threads:[~2023-11-22 21:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 16:43 [PATCH] x86/smp: Use atomic_try_cmpxchg() to micro-optimize native_stop_other_cpus() Uros Bizjak
2023-11-17 16:18 ` Dave Hansen
2023-11-17 16:37 ` Uros Bizjak
2023-11-17 17:22 ` Dave Hansen
2023-11-22 20:18 ` Uros Bizjak
2023-11-22 21:32 ` Dave Hansen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7aaa343e-365a-4c87-a139-7d26bbb50bd7@intel.com \
--to=dave.hansen@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=ubizjak@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox