From: Lukas Zapolskas <lukas.zapolskas@arm.com>
To: "Adrián Larumbe" <adrian.larumbe@collabora.com>
Cc: Boris Brezillon <boris.brezillon@collabora.com>,
Steven Price <steven.price@arm.com>,
Liviu Dudau <liviu.dudau@arm.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/7] drm/panthor: Add performance counters with manual sampling mode
Date: Fri, 16 May 2025 15:05:41 +0100 [thread overview]
Message-ID: <7ae5cc02-d969-41f3-b531-9efcf4cf93df@arm.com> (raw)
In-Reply-To: <xqxyuzrerw5b3rndifpyklkarzio2j7ioe7nyedvhli55teevf@kb6lkfueeypf>
Hello Adrián,
Thank you for reaching out about the matter. Could you please clarify what you would like
me to elaborate on? I have responded to most, if not all, of the comments you raised in that
review, including providing more information about the approach (please see [1] for more details
on the uAPI apprach).
I am also in the process of publishing a Mesa MR corresponding to the v4 of the patch series,
which will be available. It includes additional fixes discussed in RFC v2,
and I will provide a more detailed change log.
Kind regards,
Lukas Zapolskas
[1]: https://lore.kernel.org/dri-devel/55fb6aa6-89dc-404c-89fc-5c56d15d8c98@arm.com/
On 07/05/2025 20:54, Adrián Larumbe wrote:
> I wanted to review this series for quite some time but lately have found myself caught up in quite
> a few other things. I've had a look into it last week, but before I delve into it any further, I was
> wondering whether you could take some time to go over the questions and comments I left in the review
> for the previous patch series version.
>
> That way I could know what changes you introduced in response to issues I raised, and which ones are
> due to a rethinking of the whole design.
>
> I remember some of the questions I posed dealt with a genuine lack of understanding of the way
> performance counters in CSF GPUs operate, so if you could find some time to answer them or else
> point me to the right sections of the TRM I'd find the review of this latest revision a lot easier.
>
> Kind Regards,
> Adrian Larumbe
prev parent reply other threads:[~2025-05-16 14:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-01 15:48 [PATCH v3 0/7] drm/panthor: Add performance counters with manual sampling mode Lukas Zapolskas
2025-04-01 15:48 ` [PATCH v3 1/7] drm/panthor: Add performance counter uAPI Lukas Zapolskas
2025-04-07 8:29 ` Lukas Zapolskas
2025-04-01 15:48 ` [PATCH v3 2/7] drm/panthor: Add DEV_QUERY.PERF_INFO handling for Gx10 Lukas Zapolskas
2025-04-01 15:48 ` [PATCH v3 3/7] drm/panthor: Add panthor perf initialization and termination Lukas Zapolskas
2025-04-01 15:48 ` [PATCH v3 4/7] drm/panthor: Introduce sampling sessions to handle userspace clients Lukas Zapolskas
2025-04-01 15:48 ` [PATCH v3 5/7] drm/panthor: Implement the counter sampler and sample handling Lukas Zapolskas
2025-04-07 8:32 ` Lukas Zapolskas
2025-04-01 15:48 ` [PATCH v3 6/7] drm/panthor: Add suspend, resume and reset handling Lukas Zapolskas
2025-04-01 15:48 ` [PATCH v3 7/7] drm/panthor: Expose the panthor perf ioctls Lukas Zapolskas
2025-05-07 19:54 ` [PATCH v3 0/7] drm/panthor: Add performance counters with manual sampling mode Adrián Larumbe
2025-05-16 14:05 ` Lukas Zapolskas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ae5cc02-d969-41f3-b531-9efcf4cf93df@arm.com \
--to=lukas.zapolskas@arm.com \
--cc=adrian.larumbe@collabora.com \
--cc=airlied@gmail.com \
--cc=boris.brezillon@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=steven.price@arm.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox