From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from PH0PR06CU001.outbound.protection.outlook.com (mail-westus3azon11011029.outbound.protection.outlook.com [40.107.208.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96AF43033FB for ; Thu, 22 Jan 2026 08:37:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.208.29 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769071024; cv=fail; b=EDSfG7UgxQxf2dvhUE9ObRLzHvzeDOgp5rBXdEwGMXD5isY4SoECBGlEV8IINpBbq6LQx2QZnPi6SPCGrvKC+liBCOw/8NmBaUBnhW9nkTjyZwU75L2tKYSuyRGovuak8uYyBDUpf5iQ1Rfh9ekgtyi0+OV5XmGsYFPTMQrCig8= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769071024; c=relaxed/simple; bh=XYMPLQHuHLRD6UZ64D9hAD/MO8LDmMjczW0fkL/mQT0=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=PwnwxXO0dkRyxARy31LqMQNrvP7MNklCrmlBFHpqzEpGmYIBtIcKl2JRvrULiijexJivEiNg00yOJQ56UF4YAu18YSWSillSplCsN3D4ArdHQVxSWkZsU/xLGQUt1+muqv9YsZ4NhVJxEM+KX0dG2DALKwYJztIDDYoLVJmbbWU= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=0p46RVvF; arc=fail smtp.client-ip=40.107.208.29 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="0p46RVvF" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AcLU17UaiesQa9k+eIiJy+obdf8litXiisDw3QXF2H5pBTP9gXdFrxVaY+QLd37uFgjaxvt89NfVphEkprFpirp7bDYB/LqpRP6hNQCCh7eTiy2Q3KxWwReFU8OJv6gerbwzLAXtYcoAsY+1MGs/oCboBN11TsNJ6mWK2imL4Ql2qGMAFPrhGzdmC6OhZndCkYfjZqi4RVTAWdBszKr53xd4+KEgDAWy9lWT624E/MlnwqM3Udq/OpTHNJR1gHfUEOXkrwyvHCW+wuRmdBAHzRyeVZ6eFljtl63z29nfBaQXKqlsdRjJGteKRyV/poEbiXFfO818yKVGPb0qGHKLeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G6/RCSPLSBvKqjGbSt+ZoWi4f99MHBFF836npDBQNcE=; b=b5MU6MabDea9N6NRt11eDxCciGjgWqnMGNO7vjc7FN4iLTM9gkj8BNkVGFZO5shAdtlMAFFREj151HBwV0Ozo6Juc74PddDHv9ePb5VofYmralM+FwPuKjUz6QIa2WhEsig4lzCnVUqMRNfhJlbWXp7bugIg6tQhWmsvDlvZODaIoqWjMPzrZvE61z7zvzWX+Wd8a1TzR2gxAqP36SHKIkqjMgiR7RG0eT2scU5DR18liaqYE/NTt9ZyremSycqZsJFl9e/yalF6BZV0VvZuz6q/6rCxwvd1ZPUE4+zWcVwHQOrvov9vZ5WipX/kBVAdpurVdD0h9iOxX+fFcRJPzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linux.ibm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G6/RCSPLSBvKqjGbSt+ZoWi4f99MHBFF836npDBQNcE=; b=0p46RVvFoiTkZ5x9oYxQCSAqzQ9xiYf6om0vpbGGomkBTAbay5dkrSMnD1pzN33Iyxk7w9/k7eSmlSCKM2/qXr2zbd40b5GGNGjFcGewF40rJH5LcX4lyW19F5AB42S9Z0KFmCuNjfVllpNSbqyIWt+5oVJdmVW86ElOlYaBICI= Received: from PH8P220CA0022.NAMP220.PROD.OUTLOOK.COM (2603:10b6:510:345::16) by IA1PR12MB6409.namprd12.prod.outlook.com (2603:10b6:208:38b::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9542.9; Thu, 22 Jan 2026 08:36:53 +0000 Received: from CY4PEPF0000FCC2.namprd03.prod.outlook.com (2603:10b6:510:345:cafe::10) by PH8P220CA0022.outlook.office365.com (2603:10b6:510:345::16) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9542.10 via Frontend Transport; Thu, 22 Jan 2026 08:36:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by CY4PEPF0000FCC2.mail.protection.outlook.com (10.167.242.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9564.3 via Frontend Transport; Thu, 22 Jan 2026 08:36:53 +0000 Received: from SATLEXMB04.amd.com (10.181.40.145) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.2562.17; Thu, 22 Jan 2026 02:36:52 -0600 Received: from satlexmb07.amd.com (10.181.42.216) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 22 Jan 2026 02:36:52 -0600 Received: from [10.136.37.139] (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Thu, 22 Jan 2026 00:36:49 -0800 Message-ID: <7b0eb351-741b-428a-9bb3-ab0b8a0c81e2@amd.com> Date: Thu, 22 Jan 2026 14:06:44 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/8] sched/topology: Switch to assigning "sd->shared" from s_data To: Shrikanth Hegde CC: Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Chen Yu , "Gautham R. Shenoy" , "Ingo Molnar" , Peter Zijlstra , Juri Lelli , Vincent Guittot , References: <20260120113246.27987-1-kprateek.nayak@amd.com> <20260120113246.27987-4-kprateek.nayak@amd.com> Content-Language: en-US From: K Prateek Nayak In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Received-SPF: None (SATLEXMB04.amd.com: kprateek.nayak@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000FCC2:EE_|IA1PR12MB6409:EE_ X-MS-Office365-Filtering-Correlation-Id: 1014af10-de8d-46f6-4a97-08de59916503 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|7416014|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?TlNZNzdDVExsM2owWDhZWFdhYWJTdlQzcVFxRi9xclhGdDEvMkdrdGcza2tI?= =?utf-8?B?cUVCQ0JRRlVETFp2Y0lnS0txOXNIOHpZQ0ViQ1U5aEVNRUhmWGl1WTRqdUZN?= =?utf-8?B?TTcyN3ZrWGJqLzZpUS9Ha1Jwbm4yempyRStrcUQ4MWZnM2RyMEg2RU85clc0?= =?utf-8?B?Q2dINjBEdmc1N1hnb2Q4TzlBbG50U3QrVVZaZDhzck5Cc1ZuRExoK1J3ZXNT?= =?utf-8?B?NVQ2dURqdFJHenkzTmUrNHlwQXVXY2ZCNXd1eFpzM1U4Rk9vdGFDQnhYeDdZ?= =?utf-8?B?d2ZHNVByT1VjYUZ6TWduSm5EeXcxUVNXTHNCbkQzelNsUXRVNEEvdTJDRVR1?= =?utf-8?B?eFNuWElXcG5KbXB0U0I1ZkdENk5NcitoUUtyOVo5dUVhVWpCN2pVNGM1M2Ew?= =?utf-8?B?eDBmSHJsR2IvZ05RT3FPTk5yR1BGdGxJL3V4RitTSkdBL1BJUXR6MkhCYkZx?= =?utf-8?B?WEphMUN6aXBvWGNvZXd1VjZkOVpZM1FiczM5MlBwVUNhYzM0RTFtYzdnTGJm?= =?utf-8?B?Ykh1Snp4TTVCaGM5a0tESnl5c1BjUGVwU1Q4R0RMQ2tCcnJ0M2xWMVlORmVM?= =?utf-8?B?K1pwS2pqV21tejVMYTMzdVZ2K0NsbUxtcEtVSTNSOFduODRabXYwMXlYOHBT?= =?utf-8?B?SG5HVVk3UWJsc2FiR1Qvajd2dlE1Y0I5QWd2WlhBeDNjN0EzalV5a2lDSEpM?= =?utf-8?B?blRkeEljZ01od2RWUjRiOVRLOGZEOTlWK1JKWnlVWHlwbExNUlFDenRST2Ez?= =?utf-8?B?Tm1zeDVzTVIwaXQ2bGdjNTdDZ1k4eWxFbHRJcG9GMUVJaFg5OC9RN3VJTDVQ?= =?utf-8?B?ZGN1TnNQWFVWZG15eGNaNnZoQjRmWkd3TXlWQ093eGQzYmJheHgwWlBVU09l?= =?utf-8?B?RUJqQTJSYit4N2pJOE93ajBIMEkyc3FmWnpXbW1BU0hZa0pnd0lOSmtXT0hl?= =?utf-8?B?QTY0dlZOOEtJLzV6WW9TY2hqZWFQOFFIWUZiZlhrQmF2VlB1TEZxWWo1S1dV?= =?utf-8?B?L2p6ank5cHB3STdjZ2l1NStYTzVFci92Ny92R3RSblh0cUdQU0Y0dUtKWXpr?= =?utf-8?B?djdraG5WclRFRTErK2kxYmEzcFBBVTVQZHJZaW9sN3pJeDlvbmRFNXBWdWhF?= =?utf-8?B?L2I4Ui82a3lQbzBXTkwzZDNST2M2NXB5Q25KWXZqZTlCYnArUnJGcC9CTWxJ?= =?utf-8?B?eDNheVpTWEovSU95czB3aDlEdkU2MDcvZ0dvbE9DaS9zT09ZYmpXZ0I2cnJ5?= =?utf-8?B?QU9WUGlXOWVXK1hzL1NEeFVJTGtaTlJjYis2bUtDRDFzRDNDSXB3VmVYOEFQ?= =?utf-8?B?eUtPZ3U1WXRBRjRBeDlyY2RmaEVVT0l2Yjd3MFR1K3BxL2tQY1lmU3M0b0Rz?= =?utf-8?B?bVkxWWs4MGJHRU8xdGVBR3F2UVo4ZGQvUHNINytQejhzSEE2LzhDVUtDS2hv?= =?utf-8?B?Rko3VmNLVnBXKzRteUVjTGJ2cjlEcmtSVEVEdFhpK2lyRXcrZXp6Zi9ZMzRB?= =?utf-8?B?d1VjYUpVaUhoMUUwOEk5N3pmaGRJQ3ZmVVBzMVZ0NVozTkV5ZFJVelNwSjll?= =?utf-8?B?UTBNMXVFbDdqejBUM21HT05sQ3lQV0hUSUF1WnE1dmhGR3NRVmlIcnl6Umt2?= =?utf-8?B?Q1l0d1JIeFNoNFRhRTZKbjRiY0dtYS8vNndweFVWS2FPRjVydENJRTRqN2hy?= =?utf-8?B?Z3ArSitndlFPOEt1SElJSGo0WU9XVU43Z2tQaThjemhTcmcyMzNVVEZqaHZW?= =?utf-8?B?bkJGY0dBRUMyS0xkdS9WbkZHVDVLdDhOUUE4SnNnTXZOVlFRWEJQOEtVczRy?= =?utf-8?B?bTFqS1RTM0ZZdFJlbmE2eHhSVk5IM0Nsdk5tUWhmWDVGVkI1L3hBakZRK0M1?= =?utf-8?B?ZjhwdEo1alZMNlNWbkxsSmdBT0dTTEpOOW14UDFiaXR4L1MwTFcxUEd0UHhv?= =?utf-8?B?M3FWQVo2VTNwWG8ydmFyb2xNYzNqZVF2MFZPWGtOU1JTRGRaeURxRmNYQ21k?= =?utf-8?B?USsrVzhPellmeTlNRGVsb1YwNXJFRlU0WE0vQ294ekN2RkxvKytxRTQwUU42?= =?utf-8?B?U00yc0Rnd0ZQT0RyeGNMK0QyaEhFK2d1aldXMWVDdERJLzBkOGRGY3RKNmg0?= =?utf-8?B?YTU2SjJLNFJ4c0tlcytUWFQ5QkNrZWw3RHB3WVcrN2tqVUw2TEgzNFhieVND?= =?utf-8?B?RWNTWEtoOXozTG56SHI1MW9MTE9FVS80U0tRbnhsRzZib1p0cVFOcE50UnF3?= =?utf-8?B?ZnV6QTIySHdWYmhiTkNnT24rNkJBPT0=?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(376014)(7416014)(36860700013)(1800799024);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jan 2026 08:36:53.2169 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1014af10-de8d-46f6-4a97-08de59916503 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000FCC2.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6409 Hello Shrikanth, On 1/22/2026 1:42 PM, Shrikanth Hegde wrote: >> @@ -2709,6 +2720,9 @@ build_sched_domains(const struct cpumask *cpu_map, struct sched_domain_attr *att >>           if (!cpumask_test_cpu(i, cpu_map)) >>               continue; >>   +        if (atomic_read(&(*per_cpu_ptr(d.sds, i))->ref)) >> +            *per_cpu_ptr(d.sds, i) = NULL; >> + > > Can we do this claim_allocations only? I didn't do it there since we didn't have reference to the "s_data" inside claim_allocations(). If I remember this right, only init_sched_groups_capacity() has the requirement to traverse the CPUs in reverse to do update_group_capacity() when we hit the first CPU in the group. It doesn't modify the "->ref" of any allocations. I can put the claim_allocations() bits the previous loop and pass the CPU and the s_data reference so it can free both "d.sds" and all the "d.sd" bits in one place and retain this reverse loop for init_sched_groups_capacity(). Does that sound better? > sdt_alloc and free is complicated already. > >>           for (sd = *per_cpu_ptr(d.sd, i); sd; sd = sd->parent) { >>               claim_allocations(i, sd); >>               init_sched_groups_capacity(i, sd); > -- Thanks and Regards, Prateek