From: Krzysztof Kozlowski <krzk@kernel.org>
To: Tudor Ambarus <tudor.ambarus@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Jassi Brar <jassisinghbrar@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
andre.draszik@linaro.org, kernel-team@android.com,
willmcvicker@google.com, peter.griffin@linaro.org,
daniel.lezcano@linaro.org, vincent.guittot@linaro.org,
ulf.hansson@linaro.org, arnd@arndb.de
Subject: Re: [PATCH v6 2/3] firmware: add Exynos ACPM protocol driver
Date: Sun, 9 Feb 2025 12:20:47 +0100 [thread overview]
Message-ID: <7b282f8e-57a1-418a-9a24-66c103e72018@kernel.org> (raw)
In-Reply-To: <1fa54c76-d82f-483b-b577-79322908fabc@linaro.org>
On 06/02/2025 10:02, Tudor Ambarus wrote:
>
>>> + np = of_parse_phandle(dev->of_node, "exynos,acpm_ipc", 0);
>> You need bindings for this somewhere and fix the underscore->hyphen...
>> and vendor prefix. It really would not be accepted that way so please
>> post consumer bindings anywhere.
>
> There's no consumer upstreamed yet, I don't know where I shall specify
> it. How about keeping the function name and modify the declaration to
>
> +static const struct acpm_handle *acpm_get_by_phandle(struct device_node
> *np,
> + const char *property)
>
> This shall be in line with the syscon API and doesn't force me to
> introduce bindings for the consumers now.
>
Good for me.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-02-09 11:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 14:00 [PATCH v6 0/3] firmware: add Exynos ACPM protocol driver Tudor Ambarus
2025-01-16 14:00 ` [PATCH v6 1/3] dt-bindings: firmware: add google,gs101-acpm-ipc Tudor Ambarus
2025-01-16 14:00 ` [PATCH v6 2/3] firmware: add Exynos ACPM protocol driver Tudor Ambarus
2025-02-05 16:52 ` Krzysztof Kozlowski
2025-02-06 9:02 ` Tudor Ambarus
2025-02-09 11:20 ` Krzysztof Kozlowski [this message]
2025-01-16 14:00 ` [PATCH v6 3/3] MAINTAINERS: add entry for the Samsung Exynos ACPM mailbox protocol Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b282f8e-57a1-418a-9a24-66c103e72018@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=arnd@arndb.de \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=kernel-team@android.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=ulf.hansson@linaro.org \
--cc=vincent.guittot@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox