From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Ariel Silver <arielsilver77@gmail.com>,
gregkh@linuxfoundation.org, yogi.kernel@gmail.com,
straube.linux@gmail.com, dan.carpenter@linaro.org
Cc: linux-staging@lists.linux.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] Staging: rtl8192e: Declare variable with static
Date: Sun, 10 Mar 2024 09:38:47 +0100 [thread overview]
Message-ID: <7b52b937-787a-45eb-a8ba-e96f4aad006a@gmail.com> (raw)
In-Reply-To: <20240309174722.3463-1-arielsilver77@gmail.com>
On 3/9/24 18:47, Ariel Silver wrote:
> Fixed sparse warning:
> "'dm_rx_path_sel_table' was not declared. Should it be static?"
> As dm_rx_path_sel_table is used only in rtl_dm.c it should be static.
>
> Signed-off-by: Ariel Silver <arielsilver77@gmail.com>
> ---
> V2 -> V3: add patch version number and changelog
> V1 -> V2: fix checkpatch.pl warnings
> ---
> drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
> index 330dafd62656..5b52bc992a61 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
> @@ -144,7 +144,7 @@ const u8 dm_cck_tx_bb_gain_ch14[CCK_TX_BB_GAIN_TABLE_LEN][8] = {
> /*------------------------Define global variable-----------------------------*/
> struct dig_t dm_digtable;
>
> -struct drx_path_sel dm_rx_path_sel_table;
> +static struct drx_path_sel dm_rx_path_sel_table;
> /*------------------------Define global variable-----------------------------*/
>
>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
prev parent reply other threads:[~2024-03-10 8:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-09 17:47 [PATCH v3] Staging: rtl8192e: Declare variable with static Ariel Silver
2024-03-10 8:38 ` Philipp Hortmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b52b937-787a-45eb-a8ba-e96f4aad006a@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=arielsilver77@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.de \
--cc=straube.linux@gmail.com \
--cc=yogi.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox