From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 651EF263F34 for ; Thu, 9 Oct 2025 20:11:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760040683; cv=none; b=bgdeaoPkpW5JM7TYZXzKyUUxD7/IKqLukrQ+41IowXbBFUYIMqW/gVUfCnhG/c3zo0/3+2gRjDxXzsm5Bu3jyoLx0FP1E8NVRsw5egeuRxOMr0oPohMwIjp/lxxCze8qLWY6ImEn+wDGzxzrMWMmgGVNyuZfPAVj0BWrGF1arrc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760040683; c=relaxed/simple; bh=GH/isMXZuyY6n7CPnG1haS9m5ZS6KNNrdO16o7tR+Wk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DmQ8/AV07JNDPAA5hVa4nLa/Wq81PT+E7dcf2Bfhn8dgfDs/Dp/GAr1M0AM6TLVPHN8HqHTry7EqafLXFZx3uyP5RCzHdfrvpRpFb5l0eXGZ6/LM69mqKrU1SdrdPAg/iHFPHOxxkzUWN5J0Qb5Z2NwRbIwOWZJ01D4/Ptfp2iE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=CEgg8MOR; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CEgg8MOR" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-3fc36b99e92so1804156f8f.0 for ; Thu, 09 Oct 2025 13:11:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760040680; x=1760645480; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=I0bxSC9qVdAO+PHu6prllXc1vwxGvmh0YPQ8osQBxSA=; b=CEgg8MORPxtBHBJgfMMPwJj5XYaeA53FuO8l3JSVqJYfYtQCDTdAo67Px9GPCmOwzF EAyAD34u2CA3ZPwIrh2ohClDQOWR9SMfKGK/72ZcOH5A46fVeXb3PqCzAmeEDHAhg6Ys iKmaxtIQAirkEmQtHoEEarFvoGBaJDE6XwAo9ZnU3f1iDuiFXF2F2D//7x/BsizZWE7a WhBZB6aH+HfjcgKwUw4f0DNTSgc6i9z5ijsRUyzA+9/DzgOIhtdmsgqkaWHWRn6HI062 YlyiK5ZrG9MKduy//tau/CTEclMBo5PxhoI+WmABjxl5EdOX9RHuLlil2I+frZMMaRdn 67XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760040680; x=1760645480; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=I0bxSC9qVdAO+PHu6prllXc1vwxGvmh0YPQ8osQBxSA=; b=JPY34+96IQGolnvFxyugNLCKOY6/TT8kv0DUlrZlFdc3+ELfM2eGPj8ipQTHINFf5u q7qjZhJFoNhDRtsFZzgsKd+fHuUYSPb1MPcCCfPDZtOZpdAMxw1NEimTaaUa7WWVSYkN jpSzBDF2POrjPTEBB8xxE+pclS4IA0yXwFCRcY4/ASfg1b+O7CCVYXqhXK8vYo9CGqpL WC617pJtpfgjz51rMuVPjMuLkfUsSUB4yGN1a6fCU31Jo4DQtJxPgvFHH2cVYjatk2Py Nnx2vw/p+aHlvPPZqfvOCf+7HZM+4tAuTWTK2VDTwWBl19Eoz6sy6t0LMtyQlHrwwHZt qE7w== X-Forwarded-Encrypted: i=1; AJvYcCWQ54DH4KBTi+GIpZE/6xiZbV1/XyplGDpYME/D3Z/xJC3YyoxYi8/IU38IS75NHNmtzGSHW0dvJWJqX0o=@vger.kernel.org X-Gm-Message-State: AOJu0YyzVG0MAT2bmZceq1u0VQAKNwMSyvke+sQols3zTw+C6qJOZH45 6KcO1FKSXpxU/wbs/BAYgPq/aRdM8Q6JkSPBPAzVjTNuhGVsBGF8KkQDt/RTs6qusQY= X-Gm-Gg: ASbGnctnp7mO4kuoFY6RTCjzdvwMxTpJVtcHm2bA07nWmOd30yaRynOkJls/wIf94Qk UXnxRyxtvUrtSGRx7pBCLzpUECir52TBN82/32kMwexlCZb36n5mmUIj/fIyj6azFaacZWBcGZM DvEmVfzGU/zFPmMk0KDd3tskALFAgVGfuloB1ys3i2PehfJCxTLKyeDJy+IJbo3Gt6XNpyPURc6 T0yfZrBxAUmWkMKtHmRf/nG1q16ND3urT49rgwI4HKWYTzi52PkndMBXuvjTboIWOaaRWVRjg5p 3bD0NbmEyZ2PKdQNe5SnMudwhOTpO/ww+mQ8QPKDGUMa0HovbjOVsmhXIBH/Zte/E2SOaEwpi7U r9B4v3qnowWIBf4nEzde71wo/6qnppFbPpIgmh7qdUasL21ATgZBqOBZhxA== X-Google-Smtp-Source: AGHT+IFuLsi4wmsunBeslCI8cKWeFy4ZUEWU/gsK5+phruyOaGgG2/phEeGUm4ke9yIArdmP/BdHLA== X-Received: by 2002:a5d:5f96:0:b0:3ec:42f9:952b with SMTP id ffacd0b85a97d-42666a9e191mr6428067f8f.4.1760040679687; Thu, 09 Oct 2025 13:11:19 -0700 (PDT) Received: from [192.168.0.36] ([82.76.24.202]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-426ce5cf70fsm563238f8f.27.2025.10.09.13.11.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Oct 2025 13:11:19 -0700 (PDT) Message-ID: <7b861236-8317-4435-8582-bd97f545e322@linaro.org> Date: Thu, 9 Oct 2025 23:11:17 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/18] media: microchip-isc: Color correction and histogram stats To: Balamanikandan Gunasundar Cc: Chas Williams <3chas3@gmail.com>, Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Balakrishnan Sambath , Hans Verkuil , Ricardo Ribalda , Laurent Pinchart , Jacopo Mondi , Daniel Scally , Tomi Valkeinen , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Mauro Carvalho Chehab References: <20251009155251.102472-1-balamanikandan.gunasundar@microchip.com> From: Eugen Hristev Content-Language: en-US In-Reply-To: <20251009155251.102472-1-balamanikandan.gunasundar@microchip.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Bala, On 10/9/25 18:52, Balamanikandan Gunasundar wrote: > Hi, > > This patch series has a set of enhancements to the Microchip Image Sensor > Controller driver. The objective is to expand its image processing > capabilities and to improve the colors. > > This series also introduces a new stats driver that exposes the histogram > data to userspace via v4l2 controls. This allows applications such as > libcamera to access real time image statistics for advanced image > processing like automatic exposure, white balance adjustments etc. > > Balakrishnan Sambath (11): > media: microchip-isc: Enable GDC and CBC module flags for RGB formats > media: microchip-isc: Improve histogram calculation with outlier > rejection > media: microchip-isc: Use channel averages for Grey World AWB > media: microchip-isc: Add range based black level correction > media: platform: microchip: Extend gamma table and control range > media: platform: microchip: Add new histogram submodule > media: microchip-isc: Register and unregister statistics device > media: microchip-isc: Always enable histogram for all RAW formats > media: microchip-isc: fix histogram state initialization order > media: microchip-isc: decouple histogram cycling from AWB mode > media: microchip-isc: enable userspace histogram statistics export > > Balamanikandan Gunasundar (7): > media: platform: microchip: set maximum resolution for sam9x7 > media: platform: microchip: Include DPC modules flags in pipeline > media: microchip-isc: expose hue and saturation as v4l2 controls > media: microchip-isc: Rename CBC to CBHS > media: microchip-isc: Store histogram data of all channels > media: videodev2.h, v4l2-ioctl: Add microchip statistics format > media: microchip-isc: expose color correction registers as v4l2 > controls > > drivers/media/platform/microchip/Kconfig | 2 + > drivers/media/platform/microchip/Makefile | 2 +- > .../platform/microchip/microchip-isc-base.c | 373 ++++++++++-- > .../platform/microchip/microchip-isc-regs.h | 3 + > .../platform/microchip/microchip-isc-stats.c | 549 ++++++++++++++++++ > .../media/platform/microchip/microchip-isc.h | 44 +- > .../microchip/microchip-sama5d2-isc.c | 2 +- > .../microchip/microchip-sama7g5-isc.c | 73 ++- > drivers/media/v4l2-core/v4l2-ioctl.c | 1 + > include/linux/atmel-isc-media.h | 13 + > include/uapi/linux/videodev2.h | 3 + > 11 files changed, 1001 insertions(+), 64 deletions(-) > create mode 100644 drivers/media/platform/microchip/microchip-isc-stats.c > This looks interesting. I would like to see the compliance tool output for more platforms (sama7g5, sama5d2, and the new sam9x7), also the media-ctl -p , to see the topology with your new driver. Thanks, Eugen