From: Krzysztof Kozlowski <krzk@kernel.org>
To: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Linus Walleij <linusw@kernel.org>,
Maulik Shah <maulik.shah@oss.qualcomm.com>,
Shawn Guo <shengchao.guo@oss.qualcomm.com>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Pankaj Patil <pankaj.patil@oss.qualcomm.com>
Cc: brgl@kernel.org, linux-arm-msm@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] pinctrl: qcom: nord: remove duplicated pin function
Date: Wed, 6 May 2026 16:11:00 +0200 [thread overview]
Message-ID: <7b91cfa7-09d0-4a1f-a73e-250ad1e18dfa@kernel.org> (raw)
In-Reply-To: <20260506090006.10905-1-bartosz.golaszewski@oss.qualcomm.com>
On 06/05/2026 11:00, Bartosz Golaszewski wrote:
> The qdss_cti function is initialized twice in the nord_functions array.
> Remove the duplicate entry.
>
> Fixes: c24dd0826f06 ("pinctrl: qcom: add the TLMM driver for the Nord platforms")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202605061633.BJLI5voT-lkp@intel.com/
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
> ---
> drivers/pinctrl/qcom/pinctrl-nord.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-nord.c b/drivers/pinctrl/qcom/pinctrl-nord.c
> index f14361101bf4..7c21306e77ff 100644
> --- a/drivers/pinctrl/qcom/pinctrl-nord.c
> +++ b/drivers/pinctrl/qcom/pinctrl-nord.c
> @@ -1417,7 +1417,6 @@ static const struct pinfunction nord_functions[] = {
> MSM_PIN_FUNCTION(prng_rosc0),
> MSM_PIN_FUNCTION(prng_rosc1),
> MSM_PIN_FUNCTION(pwrbrk_i_n),
> - MSM_PIN_FUNCTION(qdss_cti),
> MSM_PIN_FUNCTION(qdss),
> MSM_PIN_FUNCTION(qdss_cti),
> MSM_PIN_FUNCTION(qspi),
I also see on my allyes builders -Winitializer-overrides.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
prev parent reply other threads:[~2026-05-06 14:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 9:00 [PATCH] pinctrl: qcom: nord: remove duplicated pin function Bartosz Golaszewski
2026-05-06 9:10 ` Konrad Dybcio
2026-05-06 14:11 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b91cfa7-09d0-4a1f-a73e-250ad1e18dfa@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=bartosz.golaszewski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=linusw@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=maulik.shah@oss.qualcomm.com \
--cc=pankaj.patil@oss.qualcomm.com \
--cc=shengchao.guo@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox