From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f54.google.com (mail-qv1-f54.google.com [209.85.219.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 188E3394470 for ; Mon, 24 Aug 2026 22:25:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787610337; cv=none; b=FbsMQdcTCyj9eTFexgeAzJ4Kf7lcgB+HBQ9Pw3s0tnn2yrUIxbz8wFTlImSM0EQVTD1pXN8/RtE48yX2nj9WZg9wFpMw7INiMP2Ci+KDDmuy2Z3xa7sJ1mpLkwz1abALt6LWtT53APSVzgA4vd2zN4xU6Zr7rIoUKbLhJv32d6Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787610337; c=relaxed/simple; bh=DiYaIg23voHnWic5pRIFmoyFDeYKH4RNaLdhk0wtH68=; h=Date:Message-ID:MIME-Version:Content-Type:From:To:Cc:Subject: References:In-Reply-To; b=teqV4IFfDng3Vgrn/Yq/xw9voj1snQOwde9X3BhGIXRaFy5Ch++MdRG/ByyXoPvf/z6l2siMy/2ZwF52C5C0ghiFxZoOajmvJftSDwxBfeRZ9a8pYTDz32Mqb5DKozZBJlGE48jJnwjmqSoMcWoOjV+lMr38FLMburZ157EoVfc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com; spf=pass smtp.mailfrom=paul-moore.com; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b=WyzrJ3vQ; arc=none smtp.client-ip=209.85.219.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b="WyzrJ3vQ" Received: by mail-qv1-f54.google.com with SMTP id 6a1803df08f44-8f1a8e914a9so30873486d6.1 for ; Mon, 24 Aug 2026 15:25:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1787610335; x=1788215135; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:content-transfer-encoding :content-type:mime-version:message-id:date:from:to:cc:subject:date :message-id:reply-to:content-type; bh=oGMZUUxQZBdIk0fR0JY3BBUlzUWNpfRyiBQlNEO9giM=; b=WyzrJ3vQCq0NJ61pSV/KIqHlrVjHuesAJbiTUol90cMxRS3uFxv2xSZBM09kw5/Fk8 LqKtE/NIqHOrwek0OYOjfpP3S8tPa0SbmdYZxcoGaJfJdgjsQXXHgXb6hKRmTpKqDic4 X1ukfuinQTMXySPj+Qm7IjfJU1tdc86ZWTegKayCMgIyFom2qTH2wKqWyJiG7T4qVbnh OPnxbKbB43Bpym2F9SN699Cq12We0sGGBFbb6c31kFqdO5B5/p9QuI91aX/d/T8DxUA5 r2BI9Yl7SMdBFsrA/nPqXq0tq2VO76WbsjMsf57YNIMbXSirdA5Ay43h9NCAJe0UKZdx qZsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787610335; x=1788215135; h=in-reply-to:references:subject:cc:to:from:content-transfer-encoding :content-type:mime-version:message-id:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=oGMZUUxQZBdIk0fR0JY3BBUlzUWNpfRyiBQlNEO9giM=; b=Ngxrkt6B/RXxTHHyFuVx++ayPvUEUiVOTL0WFlQFpl/ZOLYq6grunZ/nNCvS+atP05 EkspSjEv2aUos3idT6MFvHNrhNp1lcxXig6aj1DI+5ENPL6vig0c8Mfx+JXHsWbnPwe+ K/x5gUJCRcsqlCP/7639qQuC7UxbZcrmy0/bi1gI89q5VraeJ/eFGv/uB7AoBm45oqGI 2BTeSCpLdSqay+0NbG6nosKBl0yvcWsNCBtd9ZMYFmL7935lw5465KRhoA7kEdFTnSch dlSNx5/nlvNhiafY+WRl0JiZH9DYbI8EDeQeBexn7AZ3ZVucW2heVaIj+PIiqeGuWRqa Dg/A== X-Forwarded-Encrypted: i=1; AHgh+RpAUnpB97N3Jav7/TiciZfaowlVNP0Ctnq8N6hTFQo/LyuynDisk5rY/V7OLUH7NBjAniZ0anvS8Om6u1U=@vger.kernel.org X-Gm-Message-State: AFuF++m6yNU/P7WgXP4iHdO5O+uWh66DxzPxv/QyM/WuvhQVxJHZgHal J8/UVkeiLbicJtM5ORIKZlxx5HnqviLloPn87CJUaSl2hggzORTp2vo8Qg32rsHp5g== X-Gm-Gg: AR+sD12x97JPGqR5hHcg+xzjqnENA141BmQZdAt6cgdKXE8e8WEenkXQ+m1M1hz5Tht WU11e7biTEHVy02r7lzsGFDL9drw0d2IctsFNnDpTvOGNgqBdDHGqb8A0bOHoyMIKq20WHN19OG Cp5VGktlguOj/YDwHyhUTjPtHh4Q8psjI5husFc2vIvU1mLDQRrRTxVdZqVpCwF5tS5zCOcvVu1 wvda+useNywc32Hjio5RmpfDhC72auLekt2I7DfSuGLx4dpn8TCMyg9r3RbwuYZqFkaQZQxbQrM wqOwWCnZYohUID+de/mnZLi36xbEXyXlashuJdocwEJ9e7vShYQXBzlDuNl2IDgLLEQE1L6Rxiu g6bjtraLI2Sk5wCVbj2gW7AgMj7XCS3Z1lDCvEedt4h6+5boGDB0s5XCwJOGs1wGNRADTD7nrj/ 4A3S4rJ3De2vS2aTdCdAwMZjKj44RWLpB6BwEbmS9DXzraA2/0TV+fRkQQGKZyXxFAwG7zP117O dh8ft8vMg70W8kqK5qV2u3xgOT7e+tcFA== X-Received: by 2002:a05:6214:62cc:20b0:90a:9683:8403 with SMTP id 6a1803df08f44-90cb7e97566mr16403646d6.14.1787610334819; Mon, 24 Aug 2026 15:25:34 -0700 (PDT) Received: from localhost (pool-71-126-255-178.bstnma.fios.verizon.net. [71.126.255.178]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-90c93a4bea7sm72682436d6.35.2026.08.24.15.25.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 15:25:33 -0700 (PDT) Date: Mon, 24 Aug 2026 18:25:32 -0400 Message-ID: <7b9f43325dc569ddb689b02893bde8cc@paul-moore.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: pstg-pwork:20260824_1800/pstg-lib:20260824_1107/pstg-pwork:20260824_1800 From: Paul Moore To: Ricardo Robaina , audit@vger.kernel.org, linux-kernel@vger.kernel.org Cc: eparis@redhat.com, Ricardo Robaina Subject: Re: [PATCH] audit: use copied skb length in kauditd_send_multicast_skb() References: <20260810125726.775689-2-rrobaina@redhat.com> In-Reply-To: <20260810125726.775689-2-rrobaina@redhat.com> On Aug 10, 2026 Ricardo Robaina wrote: > > The netlink header's nlmsg_len was being set using the original skb > instead of the local copy passed to nlmsg_multicast(). > > While skb->len and copy->len are identical at this point following > skb_copy(), it is conceptually cleaner and safer to use the length > of the skb being actively modified and sent. Thus, this is a minor > cleanup only, no functional change expected. > > Signed-off-by: Ricardo Robaina > Reviewed-by: Bradley Morgan > --- > kernel/audit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Looks reasonable. Merged into audit/dev-staging, will be moved to audit/dev next week. -- paul-moore.com