From: Eric Dumazet <eric.dumazet@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>, Guenter Roeck <linux@roeck-us.net>
Cc: LKML <linux-kernel@vger.kernel.org>,
Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
Ben Young Tae Kim <ytkim@qca.qualcomm.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] Bluetooth: hci_qca: Use del_timer_sync() before freeing
Date: Wed, 6 Apr 2022 15:29:24 -0700 [thread overview]
Message-ID: <7bbbf503-01c8-737e-fa25-37a6d89d3354@gmail.com> (raw)
In-Reply-To: <20220406124645.3a1ce66e@gandalf.local.home>
On 4/6/22 09:46, Steven Rostedt wrote:
> On Wed, 6 Apr 2022 09:36:10 -0700
> Guenter Roeck <linux@roeck-us.net> wrote:
>
>>> So we have a chicken verses egg issue here?
>>>
>> Almost looks like it, unless I am missing something. Maybe some flag
>> is needed to prevent the timer handling code from queuing into the
>> destroyed workqueue, or the workqueue handler from updating the timer.
> That's exactly what I was thinking. I do not know all the code here. I
> could try to write a patch, but I may likely miss something.
>
> -- Steve
Take a look at
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=1946014ca3b19be9e485e780e862c375c6f98bad
Ie, use an ->live (or ->dead) field.
prev parent reply other threads:[~2022-04-06 22:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-04 22:22 [PATCH] Bluetooth: hci_qca: Use del_timer_sync() before freeing Steven Rostedt
2022-04-05 0:22 ` Eric Dumazet
2022-04-05 1:07 ` Steven Rostedt
2022-04-06 15:39 ` Guenter Roeck
2022-04-06 15:46 ` Steven Rostedt
2022-04-06 16:36 ` Guenter Roeck
2022-04-06 16:46 ` Steven Rostedt
2022-04-06 22:29 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bbbf503-01c8-737e-fa25-37a6d89d3354@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=ytkim@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox