From: Dmitry Osipenko <digetx@gmail.com>
To: Stephen Boyd <sboyd@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
Michael Turquette <mturquette@baylibre.com>,
Peter De Schrijver <pdeschrijver@nvidia.com>,
Prashant Gaikwad <pgaikwad@nvidia.com>,
Thierry Reding <thierry.reding@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
linux-tegra@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 3/4] clk: tegra20: Turn EMC clock gate into divider
Date: Sat, 2 Jun 2018 14:00:18 +0300 [thread overview]
Message-ID: <7bed6350-b6ee-1d79-39f5-bf0db2c2b102@gmail.com> (raw)
In-Reply-To: <152792144851.225090.7409061495035612435@swboyd.mtv.corp.google.com>
On 02.06.2018 09:37, Stephen Boyd wrote:
> Quoting Dmitry Osipenko (2018-05-30 08:06:45)
>> Kernel should never gate the EMC clock as it causes immediate lockup, so
>> removing clk-gate functionality doesn't affect anything. Turning EMC clk
>> gate into divider allows to implement glitch-less EMC scaling, avoiding
>> reparenting to a backup clock.
>>
>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>
> Looks ok to me, but I'm waiting for someone from Tegra side to ack it or
> review it.
>
I've already prepared v2 with some minor cleanups and additional clk patch. For
now waiting for Peter's review comments to v1.
next prev parent reply other threads:[~2018-06-02 11:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-30 15:06 [PATCH v1 0/4] Tegra20 External Memory Controller driver Dmitry Osipenko
2018-05-30 15:06 ` [PATCH v1 1/4] dt: bindings: tegra20-emc: Document interrupt property Dmitry Osipenko
2018-05-30 15:06 ` [PATCH v1 2/4] ARM: dts: tegra20: Add interrupt to External Memory Controller Dmitry Osipenko
2018-05-30 15:06 ` [PATCH v1 3/4] clk: tegra20: Turn EMC clock gate into divider Dmitry Osipenko
2018-06-02 6:37 ` Stephen Boyd
2018-06-02 11:00 ` Dmitry Osipenko [this message]
2018-05-30 15:06 ` [PATCH v1 4/4] memory: tegra: Introduce Tegra20 EMC driver Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bed6350-b6ee-1d79-39f5-bf0db2c2b102@gmail.com \
--to=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox