From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-hwmon@vger.kernel.org, "Günter Röck" <linux@roeck-us.net>,
"Jean Delvare" <jdelvare@suse.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 4/4] hwmon-nct6775: Adjust seven checks for null pointers
Date: Thu, 27 Apr 2017 11:31:21 +0200 [thread overview]
Message-ID: <7bf13cb6-55f3-c7d3-4b42-befb4a4e7d07@users.sourceforge.net> (raw)
In-Reply-To: <2f58a509-4aba-5c44-bc79-568b260ab692@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 27 Apr 2017 10:55:24 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
The script “checkpatch.pl” pointed information out like the following.
Comparison to NULL could be written …
Thus fix the affected source code places.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/hwmon/nct6775.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/hwmon/nct6775.c b/drivers/hwmon/nct6775.c
index d552ab7901a7..fe8713fb548c 100644
--- a/drivers/hwmon/nct6775.c
+++ b/drivers/hwmon/nct6775.c
@@ -1070,16 +1070,16 @@ nct6775_create_attr_group(struct device *dev,
return ERR_PTR(-EINVAL);
group = devm_kzalloc(dev, sizeof(*group), GFP_KERNEL);
- if (group == NULL)
+ if (!group)
return ERR_PTR(-ENOMEM);
attrs = devm_kcalloc(dev, repeat * count + 1, sizeof(*attrs),
GFP_KERNEL);
- if (attrs == NULL)
+ if (!attrs)
return ERR_PTR(-ENOMEM);
su = devm_kcalloc(dev, repeat * count, sizeof(*su), GFP_KERNEL);
- if (su == NULL)
+ if (!su)
return ERR_PTR(-ENOMEM);
group->attrs = attrs;
@@ -1087,7 +1087,7 @@ nct6775_create_attr_group(struct device *dev,
for (i = 0; i < repeat; i++) {
t = tg->templates;
- while (*t != NULL) {
+ while (*t) {
snprintf(su->name, sizeof(su->name),
(*t)->dev_attr.attr.name, tg->base + i);
if ((*t)->s2) {
@@ -3000,11 +3000,11 @@ static umode_t nct6775_pwm_is_visible(struct kobject *kobj,
if ((nr >= 14 && nr <= 18) || nr == 21) /* weight */
if (!data->REG_WEIGHT_TEMP_SEL[pwm])
return 0;
- if (nr == 19 && data->REG_PWM[3] == NULL) /* pwm_max */
+ if (nr == 19 && !data->REG_PWM[3]) /* pwm_max */
return 0;
- if (nr == 20 && data->REG_PWM[4] == NULL) /* pwm_step */
+ if (nr == 20 && !data->REG_PWM[4]) /* pwm_step */
return 0;
- if (nr == 21 && data->REG_PWM[6] == NULL) /* weight_duty_base */
+ if (nr == 21 && !data->REG_PWM[6]) /* weight_duty_base */
return 0;
if (nr >= 22 && nr <= 35) { /* auto point */
--
2.12.2
next prev parent reply other threads:[~2017-04-27 9:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 9:27 [PATCH 0/4] hwmon-NCT: Fine-tuning for four function implementations SF Markus Elfring
2017-04-27 9:28 ` [PATCH 1/4] hwmon-nct6683: Use devm_kcalloc() in nct6683_create_attr_group() SF Markus Elfring
2017-04-27 9:29 ` [PATCH 2/4] hwmon-nct6683: Adjust five checks for null pointers SF Markus Elfring
2017-04-27 9:30 ` [PATCH 3/4] hwmon-nct6775: Use devm_kcalloc() in nct6775_create_attr_group() SF Markus Elfring
2017-04-27 9:31 ` SF Markus Elfring [this message]
2017-04-27 12:50 ` [PATCH 0/4] hwmon-NCT: Fine-tuning for four function implementations Jean Delvare
2017-04-27 13:23 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bf13cb6-55f3-c7d3-4b42-befb4a4e7d07@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=jdelvare@suse.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox