From: Jiri Slaby <jirislaby@kernel.org>
To: Trevor Woerner <twoerner@gmail.com>,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH 3/3] serial: 8250_fintek.c: Clean up set_termios() message
Date: Fri, 11 Mar 2022 10:23:22 +0100 [thread overview]
Message-ID: <7bf43ee7-549e-c98c-1ca9-b5060124c94b@kernel.org> (raw)
In-Reply-To: <20220311070203.18159-3-twoerner@gmail.com>
On 11. 03. 22, 8:02, Trevor Woerner wrote:
> Clean up the status message that is given in the case where a custom
> termios() is not installed.
>
> Signed-off-by: Trevor Woerner <twoerner@gmail.com>
> ---
> drivers/tty/serial/8250/8250_fintek.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_fintek.c b/drivers/tty/serial/8250/8250_fintek.c
> index 03ad2354d808..dcab23d1965e 100644
> --- a/drivers/tty/serial/8250/8250_fintek.c
> +++ b/drivers/tty/serial/8250/8250_fintek.c
> @@ -333,7 +333,7 @@ static void fintek_8250_set_termios(struct uart_port *port,
> default:
> /* Don't change clocksource with unknown PID */
> dev_warn(port->dev,
> - "%s: pid: %x Not support. use default set_termios.\n",
> + "%s: chipID: %x not supported; using default set_termios.\n",
> __func__, pdata->pid);
So the variable calls it PID, the comment calls it PID and you change
the report to chipID. Why?
thanks,
--
js
suse labs
next prev parent reply other threads:[~2022-03-11 9:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-11 7:02 [PATCH 3/3] serial: 8250_fintek.c: Clean up set_termios() message Trevor Woerner
2022-03-11 9:23 ` Jiri Slaby [this message]
2022-03-11 14:34 ` Trevor Woerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bf43ee7-549e-c98c-1ca9-b5060124c94b@kernel.org \
--to=jirislaby@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=twoerner@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox