From: "Wysocki, Rafael J" <rafael.j.wysocki@intel.com>
To: Christian Loehle <christian.loehle@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
Vincent Guittot <vincent.guittot@linaro.org>
Subject: Re: [PATCH] idle: Remove stale RCU comment
Date: Fri, 14 Jun 2024 15:59:14 +0200 [thread overview]
Message-ID: <7c223157-3e82-4cf8-aec7-4a7dd6e32d76@intel.com> (raw)
In-Reply-To: <5b936388-47df-4050-9229-6617a6c2bba5@arm.com>
On 6/3/2024 5:30 PM, Christian Loehle wrote:
> The call of rcu_idle_enter() from within cpuidle_idle_call() was
> removed in commit 1098582a0f6c ("sched,idle,rcu: Push rcu_idle deeper
> into the idle path") which makes the comment out of place.
>
> Signed-off-by: Christian Loehle <christian.loehle@arm.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> kernel/sched/idle.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/kernel/sched/idle.c b/kernel/sched/idle.c
> index 6135fbe83d68..3cc1a592d9a1 100644
> --- a/kernel/sched/idle.c
> +++ b/kernel/sched/idle.c
> @@ -179,12 +179,6 @@ static void cpuidle_idle_call(void)
> return;
> }
>
> - /*
> - * The RCU framework needs to be told that we are entering an idle
> - * section, so no more rcu read side critical sections and one more
> - * step to the grace period
> - */
> -
> if (cpuidle_not_available(drv, dev)) {
> tick_nohz_idle_stop_tick();
>
prev parent reply other threads:[~2024-06-14 13:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 15:30 [PATCH] idle: Remove stale RCU comment Christian Loehle
2024-06-05 14:54 ` [tip: sched/core] " tip-bot2 for Christian Loehle
2024-06-14 13:59 ` Wysocki, Rafael J [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c223157-3e82-4cf8-aec7-4a7dd6e32d76@intel.com \
--to=rafael.j.wysocki@intel.com \
--cc=christian.loehle@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox