From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B16D6C6FA82 for ; Wed, 14 Sep 2022 11:36:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229864AbiINLgP (ORCPT ); Wed, 14 Sep 2022 07:36:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229627AbiINLgL (ORCPT ); Wed, 14 Sep 2022 07:36:11 -0400 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9AC07C1A3; Wed, 14 Sep 2022 04:36:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663155370; x=1694691370; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=/UyNS1z5553flzYh+TOYHe0+TXBOSWmCkQFcTXHq+KU=; b=Asx85HhUSGiNp8TarWw2oAUHa1WpfTULFz/rezyFT+ZCHij8Wx0RXsbk +DZRHSnZrgPrV/zZLMhPukPqHeQPoi78LWpgbmSr07rKOsmxfXAuY+/IX noqlNoGveEOwy7Q8iQwpWJGZ+zAwEHNby0d55fU7uKiY67c3NkNdWphn9 078GSi8yeebA/GozuCr0NTT1VJIc6SVxUCjzJ0TdHNb7Zhr5XhCDobvU/ aXxt3rROrlYp64T8/MjM5lCsFZOgcFENkQ4/zxjo/EnyEgKOn7e0onkvU qkS5VOjl35P2C+v5YpRXCCWmA+shvyxm/UYr57cTq/yD7nrii8ijpeHXp Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10469"; a="278133852" X-IronPort-AV: E=Sophos;i="5.93,315,1654585200"; d="scan'208";a="278133852" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2022 04:36:10 -0700 X-IronPort-AV: E=Sophos;i="5.93,315,1654585200"; d="scan'208";a="567978194" Received: from rwathan-mobl1.ger.corp.intel.com (HELO [10.213.220.95]) ([10.213.220.95]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2022 04:36:04 -0700 Message-ID: <7c3cc265-869b-b2fc-43f2-d2cbd0bc142c@intel.com> Date: Wed, 14 Sep 2022 04:36:02 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v13 1/3] x86/tdx: Add TDX Guest attestation interface driver Content-Language: en-US To: Kuppuswamy Sathyanarayanan , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Shuah Khan Cc: "H . Peter Anvin" , Greg Kroah-Hartman , "Kirill A . Shutemov" , Tony Luck , Andi Kleen , Kai Huang , Wander Lairson Costa , Isaku Yamahata , marcelo.cerri@canonical.com, tim.gardner@canonical.com, khalid.elmously@canonical.com, philip.cox@canonical.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org References: <20220909192708.1113126-1-sathyanarayanan.kuppuswamy@linux.intel.com> <20220909192708.1113126-2-sathyanarayanan.kuppuswamy@linux.intel.com> From: Dave Hansen In-Reply-To: <20220909192708.1113126-2-sathyanarayanan.kuppuswamy@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/9/22 12:27, Kuppuswamy Sathyanarayanan wrote: > > arch/x86/coco/tdx/tdx.c | 115 ++++++++++++++++++++++++++++++++ > arch/x86/include/uapi/asm/tdx.h | 56 ++++++++++++++++ > 2 files changed, 171 insertions(+) > create mode 100644 arch/x86/include/uapi/asm/tdx.h The SEV equivalent of this in in: drivers/virt/coco/sev-guest/sev-guest.c right? Why did you choose a different location? Also, can you please study the SEV implementation a bit? It might help you find problems like the ioctl() return code issue. The SEV driver appears to have gotten that right.