From: Georgi Djakov <djakov@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
quic_okukatla@quicinc.com, linux-arm-msm@vger.kernel.org,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Vinod Koul <vkoul@kernel.org>
Subject: Re: [PATCH] dt-bindings: interconnect: qcom: Do not require reg for sc8180x virt NoCs
Date: Sat, 24 Aug 2024 02:39:49 +0300 [thread overview]
Message-ID: <7c75defd-372b-42cc-897a-eb46e4a8966e@kernel.org> (raw)
In-Reply-To: <31173e79-4b2d-4027-a4a2-61071206f387@kernel.org>
On 30.07.24 17:32, Krzysztof Kozlowski wrote:
> On 30/07/2024 16:10, djakov@kernel.org wrote:
>> From: Georgi Djakov <djakov@kernel.org>
>>
>> The virtual interconnect providers do not have their own IO address space,
>> but this is not documented in the DT schema and the following warnings are
>> reported by dtbs_check:
>>
>> sc8180x-lenovo-flex-5g.dtb: interconnect-camnoc-virt: 'reg' is a required property
>> sc8180x-lenovo-flex-5g.dtb: interconnect-mc-virt: 'reg' is a required property
>> sc8180x-lenovo-flex-5g.dtb: interconnect-qup-virt: 'reg' is a required property
>> sc8180x-primus.dtb: interconnect-camnoc-virt: 'reg' is a required property
>> sc8180x-primus.dtb: interconnect-mc-virt: 'reg' is a required property
>> sc8180x-primus.dtb: interconnect-qup-virt: 'reg' is a required property
>>
>> Fix this by adding them to the list of compatibles that do not require
>> the reg property.
>
> So I guess we are giving up on
> https://lore.kernel.org/all/20230530162454.51708-4-vkoul@kernel.org/
> ?
Thanks for the pointer! That approach is fine too, but i was expecting
a re-send and then later completely forgot about it. I have a slight
preference towards my patch, because it is more compact, but i can also
revive Vinod's patch if you think that it would be a better pattern to
follow in the long term.
BR,
Georgi
next prev parent reply other threads:[~2024-08-23 23:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 14:10 [PATCH] dt-bindings: interconnect: qcom: Do not require reg for sc8180x virt NoCs djakov
2024-07-30 14:32 ` Krzysztof Kozlowski
2024-08-23 23:39 ` Georgi Djakov [this message]
2024-08-24 6:19 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c75defd-372b-42cc-897a-eb46e4a8966e@kernel.org \
--to=djakov@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=quic_okukatla@quicinc.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox