From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Aaron Lu <aaron.lu@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org, Olivier Dion <odion@efficios.com>,
michael.christie@oracle.com
Subject: Re: [RFC PATCH v5] sched: Fix performance regression introduced by mm_cid
Date: Thu, 13 Apr 2023 11:11:14 -0400 [thread overview]
Message-ID: <7c8e5b5c-2039-8477-1d79-61cd450da00c@efficios.com> (raw)
In-Reply-To: <20230413143744.GA221757@ziqianlu-desk2>
On 2023-04-13 10:37, Aaron Lu wrote:
> On Thu, Apr 13, 2023 at 10:02:48AM -0400, Mathieu Desnoyers wrote:
>> Introduce per-mm/cpu current concurrency id (mm_cid) to fix a PostgreSQL
>> sysbench regression reported by Aaron Lu.
>
> Initial test using postgres_sysbench showed the lock contention is gone :-)
> Will check how it affects hackbench tomorrow.
That's good news! Not unexpected though.
One thing to look closely at is whether it's just that the qspinlocks
are gone from the profiles but replaced by time spent in __mm_cid_get()
due to cache-line bouncing of find-first-zero/test-and-set on the per-mm
cid bitmap.
But if both are really gone from the profiles, then it's really good news.
Thanks,
Mathieu
--
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com
next prev parent reply other threads:[~2023-04-13 15:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 14:02 [RFC PATCH v5] sched: Fix performance regression introduced by mm_cid Mathieu Desnoyers
2023-04-13 14:37 ` Aaron Lu
2023-04-13 15:11 ` Mathieu Desnoyers [this message]
2023-04-14 2:59 ` Aaron Lu
2023-04-14 3:06 ` Aaron Lu
2023-04-13 15:10 ` Peter Zijlstra
2023-04-13 15:27 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c8e5b5c-2039-8477-1d79-61cd450da00c@efficios.com \
--to=mathieu.desnoyers@efficios.com \
--cc=aaron.lu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.christie@oracle.com \
--cc=odion@efficios.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox