From: Markus Elfring <Markus.Elfring@web.de>
To: vulab@iscas.ac.cn, brcm80211-dev-list.pdl@broadcom.com,
brcm80211@lists.linux.dev, linux-wireless@vger.kernel.org
Cc: stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
"Arend van Spriel" <arend.vanspriel@broadcom.com>,
"Christophe Jaillet" <christophe.jaillet@wanadoo.fr>,
"Kalle Valo" <kvalo@kernel.org>, "Ondřej Jirman" <megi@xff.cz>,
"Sai Krishna" <saikrishnag@marvell.com>
Subject: Re: [PATCH] brcm80211: fmac: Add error handling for brcmf_usb_dl_writeimage()
Date: Wed, 9 Apr 2025 10:36:31 +0200 [thread overview]
Message-ID: <7cd21e2c-0a28-4eff-9dba-e5a730aa5a92@web.de> (raw)
In-Reply-To: <20250406084515.2991-1-vulab@iscas.ac.cn>
> The function brcmf_usb_dl_writeimage() calls the function
> brcmf_usb_dl_cmd() but dose not check its return value. The
* Wording suggestion:
The brcmf_usb_dl_cmd() function is called here.
Unfortunately, its return value was not checked so far.
* You may occasionally put more than 60 characters into text lines
of such a change description.
* I propose to replace the word “for” by “in” (before function names)
in some summary phrases.
Regards,
Markus
prev parent reply other threads:[~2025-04-09 8:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-06 8:45 [PATCH] brcm80211: fmac: Add error handling for brcmf_usb_dl_writeimage() Wentao Liang
2025-04-09 8:36 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7cd21e2c-0a28-4eff-9dba-e5a730aa5a92@web.de \
--to=markus.elfring@web.de \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211@lists.linux.dev \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=megi@xff.cz \
--cc=saikrishnag@marvell.com \
--cc=stable@vger.kernel.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox