From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85DE936606C for ; Tue, 10 Mar 2026 09:57:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773136636; cv=none; b=XRTGsc6BXETRBnKyzHxtdTLrUODoy8ow3itDYxfW33GVWhgPL/L7wbTHvsz2GRAm5rqaNF6/kKv7muR2u5DWhvCUTXirfMDgLsu9oyE7O+T1Tl4lnj+GD8P+v2v6SxgMNWgSJEhbnfGwKYMQMEu41WlFC7hMD/bK12TRq3R/SqY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773136636; c=relaxed/simple; bh=CbrtszZqY4+hGNS2oDyG5DABGwPuACbTE4Q/fV3gqfo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JFikob95yNemT/PhIAEelM0dcbMK22TjTn02oBxFEO+4ki6eJLDike7NyxbqV10JRddKyxgwt2Upr5QP4/itrrLhFes8gfZXAOuI0Y9tDZrnLiGINmjjmU0HQ2T8WHGNACWXVroo+ljsuQ80M/elM1wCp7jLbuAV4nBHYl3ukHc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bM29PPBA; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ArEKpWJy; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bM29PPBA"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ArEKpWJy" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62A9Cu8b3087358 for ; Tue, 10 Mar 2026 09:57:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6oJ8QQt604h4CfSsQepU3v+GHYIoK3WGwrJxaSWp0RU=; b=bM29PPBAOfK0D3uO ml3hIfgefl30u0LjMXnpy4nUYL85G/cEds2e5/kBbiqC9ctGt0Rg9xewFlv+bowf xpYjgzSj4Dy9TPBlCmBXYexZkzHfOvRwjBz2rV8i+Mt4PStfAt7DZC/nAmt9Nw15 /IGuGCecOGf3hN8IV17tfwr8mgJTSUIyftSW31id2pZu+r6nMd6ce/24ppxrZZqs r5rxs9J+VWOU3l0Jo8Yb7aWIKqF9nwiw5pdXy6MM24RTUDYRr+jGa2UskUuovWFO AA0dky8LS14sXa2uBNrJhVIdFUgWK3jNdtKlMooKWWw3+2tx11hsreyrcc0kXql3 /YvAFA== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4csxy83uw7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Mar 2026 09:57:14 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-89a01982dc5so61583006d6.3 for ; Tue, 10 Mar 2026 02:57:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773136634; x=1773741434; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6oJ8QQt604h4CfSsQepU3v+GHYIoK3WGwrJxaSWp0RU=; b=ArEKpWJyFDPARN2QSllZaqbY9HWAmwd/3Cg3SnODpsC72CEut8/KCY73tsNcL+csxu kDsjVGVXEMGWs2GqAHPmtLwiMdcy9bRCfw+SG7OLJT9/GPYyjNdot9WtqOL1RfhvV7SD WYoxZw91Lg68k6XRWkriBQYdVKwOz9FnSeBP0EHq/46dZDEpS4EGJrAhm1ZYEpPR62w7 kXd086gX+qftHKlI8zZB9w43vZlQLTbcGQK8jAD7ENr+Tf9ZgE3oU8FW6kFfcxljubcr Z3Ua7ttZH78jZlZ+KC/OtTL/TcLUPx3YzFasX8sqhBFhsNDMjQ6LgA8iNTc1iTx+q9qy FTAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773136634; x=1773741434; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6oJ8QQt604h4CfSsQepU3v+GHYIoK3WGwrJxaSWp0RU=; b=cB8biUsh1nLMwjPLFj5NthLGJTCxPauXwl78B1Fds52xQSWU/Pt/X9jatOWC2fghgi 5I3JiYTe1wu9vs2D3p0G03NyEBn5yvDC7SjK5LJA1ONIDED88PGtd4znwjrV1pPAb7Ll IxyEdzdLfceLCsHPn0pVGqRhAnShJooo0AyHuwzJ6D9e2EOBL+yQnuG5kuGPoXqKEypC WX9jIsMEA8Ccmc1bYZ2eNcv5Rjcihmt+99W7dhSALSBE5Ukaq8UR5YaVqJ3IxgDwalHu ZOBcDlUte6ZxLv0MfbRcGroNABKn5dx6wKMsTTVpJ8c1rSGlctx346E3vT6dI4na51QL BrQQ== X-Gm-Message-State: AOJu0Yzq4PnFF7DyC/T64amE2X6hj0cgv9lA9sVkCvP7T+CkI083A0V9 2+11BjDcPiZmcfzgq4CgAciLwk4mBVVTbJOOXT/Jk5P4QX5nkpfqJ8DrRdOpVu5z+4OlXXSKH7e y/pCA96cFE1y9StzKgAI/JflGfe/rSpdABnQ2xbTWKBBkRpa/eKCO9Cr8tot60PL/r9o= X-Gm-Gg: ATEYQzxGiXWR31IUgIqtGkUM1RKFl2PH9i0jF2PrZFzmn+yAQIVfswulvBVOVQZgC1c iu/MyIgomPfcS3LodcXYnph39V46/8YXDVR1LjJUtJTSAViJnxJOY97b8O25nwIMRUX2NSgoyqJ 6sIjq9vEEmU7FSlOH1+o9Ludp4Ge4EwfspIxIrGD7SGsb/x67FfoHqWdQ0oMLsHzT2DVRfmR6Ms X9fwalaeCPrOTV/JI4TXdb2bUeLkUn9yLgkqLv3ylnsQQjUgoNaxQANj10qBwW1GfY0rwaSdbiV Vsz9EPbchXdvABBxggi5Pk2HCVnQdyva6bE5Oq9KIpfptd4rYI6IBOd1gpIAQ+N+gCqcHm4nEIm 9G6BlmtQeSi8nkCF02MgCBZRpt+T5nUqO+0NLvjJR0IsJFw24xsjnb6WW4MOOekLwTGbldwQdnx /ROOI= X-Received: by 2002:a05:6214:4e1b:b0:89a:49ba:b58a with SMTP id 6a1803df08f44-89a49bab894mr82170266d6.6.1773136633823; Tue, 10 Mar 2026 02:57:13 -0700 (PDT) X-Received: by 2002:a05:6214:4e1b:b0:89a:49ba:b58a with SMTP id 6a1803df08f44-89a49bab894mr82169946d6.6.1773136633432; Tue, 10 Mar 2026 02:57:13 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b942ef483f3sm447860466b.9.2026.03.10.02.57.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Mar 2026 02:57:11 -0700 (PDT) Message-ID: <7d036c96-e257-460c-a91b-deee0b9c348b@oss.qualcomm.com> Date: Tue, 10 Mar 2026 10:57:07 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/8] soc: qcom: qmi: Enumerate the service IDs of QMI To: Daniel Lezcano , konradybcio@kernel.org, andersson@kernel.org Cc: linux-kernel@vger.kernel.org, Alex Elder , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jeff Johnson , Mathieu Poirier , Srinivas Kandagatla , Jaroslav Kysela , Takashi Iwai , Kees Cook , Greg Kroah-Hartman , Arnd Bergmann , Mark Brown , Wesley Cheng , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, ath11k@lists.infradead.org, ath12k@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-sound@vger.kernel.org References: <20260309230346.3584252-1-daniel.lezcano@oss.qualcomm.com> <20260309230346.3584252-2-daniel.lezcano@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260309230346.3584252-2-daniel.lezcano@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=SvmdKfO0 c=1 sm=1 tr=0 ts=69afeafa cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=7MBKnE05AAAA:20 a=EUspDBNiAAAA:8 a=Lti85_ANQs6YWTYAGLkA:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 a=bA3UWDv6hWIuX7UZL3qL:22 X-Proofpoint-GUID: OlgvwDqZVSIBa2GM2B8Ab6oOQtNe_pQV X-Proofpoint-ORIG-GUID: OlgvwDqZVSIBa2GM2B8Ab6oOQtNe_pQV X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEwMDA4NCBTYWx0ZWRfX5wBswmn/8ldg /yveurECcvGMgD57/W6R5pgGP8eaO/2gYQdBocGmQLqPojp/gi7QZKN3NZf62sGatfu5WVF2AFh vs9Oz1/LyKK+ltqk6nj8iizm0hBgpyU6CWXBSS150DFd2cLnM0cjdc93WsgXthlNxztMBB2IxfL SiO+VWmdSRdtWdp3pVon8/+VGCvXRYrlXHvEckGgHsBNUS86oK1LVOhAYW+oAIkl30q81trPbiP Wdb4AcsY26xLlTjpKPtFjJdrJElOj4ziwdwEkvgEVw8ipEno1diD6BarR4jxpdrxpMEtPMR05j9 AvDQpPo50h9LBSUuqANsvcMZTuqdQL9eXLiWoW4lFv++F10qfENnlexjnWuVpWg3ZaIPAKseDvz b31+EGJSdvbbiy12Wl52JXJ8Z79cY1nDNbLcesd76uhngM6MJI5jI1ZA9vTXBBSr4RZ5Kkhs105 5avDXNaLuqaf1XkkRjQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-10_01,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 impostorscore=0 spamscore=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 adultscore=0 bulkscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603100084 On 3/10/26 12:03 AM, Daniel Lezcano wrote: > The QMI framework proposes a set of services which are defined by an > integer identifier. The different QMI client lookup for the services > via this identifier. Moreover, the function qmi_add_lookup() and > qmi_add_server() must match the service ID but the code in different > places set the same value but with a different macro name. These > macros are spreaded across the different subsystems implementing the > protocols associated with a service. It would make more sense to > define them in the QMI header for the sake of consistency and clarity. > > This change use an unified naming for the services and enumerate the > ones implemented in the Linux kernel. More services can come later and > put the service ID in this same header. > > Signed-off-by: Daniel Lezcano > --- > include/linux/soc/qcom/qmi.h | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/include/linux/soc/qcom/qmi.h b/include/linux/soc/qcom/qmi.h > index 291cdc7ef49c..b8d07f2c07e7 100644 > --- a/include/linux/soc/qcom/qmi.h > +++ b/include/linux/soc/qcom/qmi.h > @@ -92,6 +92,18 @@ struct qmi_elem_info { > #define QMI_ERR_INCOMPATIBLE_STATE_V01 90 > #define QMI_ERR_NOT_SUPPORTED_V01 94 > > +/* > + * Enumerate the IDs of the QMI services In case that's useful: https://github.com/linux-msm/qrtr/blob/master/src/lookup.c#L23 Konrad